Repository navigation
feat(ledger): scope reconciliation calls to an entity; move a calendar's start - #246
Merged
Merged
Conversation
…r's start record_statement_balance, preview_reconciliations and refresh_reconciliations take an entity_id, so a subsidiary's statement and checks run on its own books rather than the group parent's. change_calendar_start moves an entity's first open month before its first close. Parity with the TypeScript facade. Claude-Session: https://claude.ai/code/session_01AQkGGPDmpba9eBV9PkLTfv
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Facade support for two server capabilities that are already live (robosystems v1.16.10 and v1.16.11). This keeps the Python facade in step with the TypeScript one (typescript-client #262), which roboledger-app uses.
Reconciliation per entity. These now take an optional keyword
entity_id; omitted, the group parent, as before:record_statement_balance;preview_reconciliations;refresh_reconciliations.Until now a caller could not record a statement or run the checks against a subsidiary.
change_calendar_start(graph_id, first_open_period, note=None, *, entity_id=None)moves an entity's first open month, allowed until its first close. It returns the calendar and how many months were opened or removed.Contract tier
Additive to the stable tier: new optional parameters and one new method. Nothing is removed and no default changes. That makes it a client minor.
The bodies leave
entity_idunset when none is given, so the requests are unchanged for existing callers.Test plan
entity_idwhen an entity is named;changeCalendarStartsends its body and reads the counts back.just test-allpasses: 673 tests, ruff and basedpyright clean.🤖 Generated with Claude Code
https://claude.ai/code/session_01AQkGGPDmpba9eBV9PkLTfv