Repository navigation
feat(ledger): information blocks, mappings, reports and schedules take an entity - #244
Merged
Merged
Conversation
…e an entity get_information_block and list_information_blocks take entity_id and the envelope names the entity it read; list_mappings names whose chart each mapping maps and takes entity_id; get_mapping_candidates narrows by the entity's style; create_report and create_schedule pass entity_id through.
3 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The Python facade side of RoboFinSystems/robosystems#1752, which scopes information-block reads to one entity of a reporting group. Parity with RoboFinSystems/robosystems-typescript-client#259.
get_information_block/list_information_blockstakeentity_id; the envelope selectsentityId, the entity it read.list_mappings(graph_id, entity_id=...): each mapping carriesentity_id(whose chart it maps from), and the argument keeps one entity's.get_mapping_candidates(..., entity_id=...)narrows by that entity's reporting style.create_report(..., entity_id=...)andcreate_schedule(..., entity_id=...)pass the entity through.schema.graphqlrefreshed from the local stack running #1752. It also picks upeventBlocks(eventClass), which shipped in v1.16.8 and was missing from the snapshot. Generated REST models pick upCreateScheduleRequest.entity_id, the envelope'sentity_id, and the reworded entity defaults.Additive only → minor. Touches no symbol the integration template imports.
Waits on the server: the documents name
entityIdarguments and fields that a server serves only once it carries robosystems#1752, so merge and publish this after the robosystems release that includes #1752 is deployed to prod.Test plan
just generate-sdk+just generate-graphqlagainst the local stackjust test-all: 671 passed, ruff + format + basedpyright cleanentity_idon the row),create_reportwire body,create_schedulepayload with and without an entity🤖 Generated with Claude Code