Repository navigation
feat(connections): shadow write policy and the shadow close receipt - #243
Merged
Merged
Conversation
Regenerated from robosystems #1733 and #1738. The write-policy request takes 'qb_authoritative' or 'shadow'; 'native' is no longer accepted, since it is what disconnecting or severing leaves. The close receipt and the period-drafts read carry the shadow fields.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Regenerated from the server after robosystems #1733 (shadow close) and #1738 (write-policy ladder). These fields reach the hosted API with the next server release after v1.16.5; until then the server rejects
shadowand omits the new receipt fields.Changes
SetWritePolicyRequestWritePolicy— nowqb_authoritativeorshadow.nativeis removed: it is what disconnecting or severing a connection leaves, and the server refuses it for a live connection.ClosePeriodResponse—shadow,entries_shadowed,gate_findings, andgate_finding_counts(new modelClosePeriodResponseGateFindingCounts).shadow,shadowedCount, and each draft'scloseDisposition.LinkBankAccountResponse.changed.Breaking Changes
None in the stable tier. Removing
nativefromSetWritePolicyRequestWritePolicyis a generated-tier change and rides a client minor; it belongs in the release notes. No facade, the integration template, or the three apps send it.Testing
just test-all: 667 passed, 17 skipped; ruff, format, and basedpyright clean.🤖 Generated with Claude Code