Repository navigation
feat(ledger): bank accounts read and link-bank-account facade - #241
Merged
Merged
Conversation
Regenerated from robosystems main after #1722: the link-bank-account operation, the bankAccounts GraphQL field and the schema snapshot. LedgerClient gains list_bank_accounts (the group's bank and card accounts with their entity, source and connection health) and link_bank_account (point a feed account at a chart account, including one in a subsidiary's chart). Claude-Session: https://claude.ai/code/session_01BY3uYE5zMjjFHnjiZfiJu8
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Regenerated from robosystems
mainafter #1722 (thelink-bank-accountoperation, thebankAccountsGraphQL field, the schema snapshot), plus the two facade methods. The regen carries no other drift: the generated diff is the new operation, its models, and the new query's typed models.Changes
api/robo_ledger_setup/link_bank_account.pywithLinkBankAccountRequest/LinkBankAccountResponseand the envelope models;graphql/generated/list_ledger_bank_accounts.pyfrom the new documentgraphql/operations/ledger/ListLedgerBankAccounts.graphql;schema.graphqlrefreshed.LedgerClient.list_bank_accounts(graph_id, entity_id=None)— the group's bank and card accounts: every chart account a feed books to, or that a source system types as a bank or card account, with the entity whose chart it is in, what writes to it, and the connection's status and last sync.LedgerClient.link_bank_account(graph_id, body)— point a feed account at a chart account (element_id), or create one in an entity's chart (entity_idalone); how a feed account is bound to a subsidiary.Breaking Changes
None. Additive; a client minor.
Testing
just format,just lint,just typecheck,just test(667 passed) all pass.The facade selects the new
bankAccountsfield, so it answers once the server release carrying robosystems #1722 is deployed; the consumers pin the client by lockfile and pick it up on their own bump.🤖 Generated with Claude Code
https://claude.ai/code/session_01BY3uYE5zMjjFHnjiZfiJu8