Move image.py out of analysis so importing lensboy doesn't pull in matplotlib#33
Merged
Robertleoj merged 1 commit intoJun 3, 2026
Merged
Conversation
charuco.py (re-exported on the core path) imported to_gray from lensboy.analysis.image. Importing that submodule runs lensboy/analysis/__init__.py, which eagerly imports plots.py -> matplotlib, so every `import lensboy` transitively pulled in matplotlib and scipy. to_gray/to_color are generic uint8 image helpers with no dependency on analysis, so move image.py to the top-level lensboy package and update the two import sites. Core code no longer touches the optional analysis subpackage at load time. Cold `import lensboy` (median of 12 fresh interpreters, arm64): before 382 ms (94 matplotlib + 175 scipy modules) -> after 73 ms (0/0). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
import lensboytransitively imported matplotlib and scipy. The core path re-exportsextract_frames_from_charuco, andcharuco.pyimportedto_grayfromlensboy.analysis.image. Importing that submodule forceslensboy/analysis/__init__.pyto run, which eagerly importsplots.py→ matplotlib. So every core import paid the full analysis-stack cost, even thoughto_gray/to_colorare generic uint8 image helpers with no dependency onanalysis.Fix
Move
image.pyfromlensboy/analysis/to top-levellensboy/, where it belongs (used by both corecharuco.pyandanalysis/plots.py), and update the two import sites. Core code no longer touches the optionalanalysissubpackage at load time.Impact
Cold
import lensboy, measured over 12 fresh interpreters (arm64):~5× faster import; no matplotlib/scipy loaded unless
lensboy.analysisis explicitly used.🤖 Generated with Claude Code