perf: lazy-load images in markdown preview - #136
Open
shrutig-blip wants to merge 1 commit into
Open
Conversation
|
@shrutig-blip is attempting to deploy a commit to the rinava's projects Team on Vercel. A member of the Team first needs to authorize it. |
Contributor
Author
|
Hi @Rinava! I've addressed #43 by adding a custom image renderer that lazy-loads Markdown images while preserving the existing props and providing an empty alt fallback. I also kept the native |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a custom image renderer to the Markdown preview to improve loading performance.
Changes
imgrenderer inMarkdownPreviewloading="lazy"for off-screen imagesdecoding="async"for asynchronous image decodingsrc,title, etc.) by spreading the propsalttext to""for accessibility<img>element since Markdown images can reference arbitrary user-supplied URLs, makingnext/imageunsuitableTesting
npm run lintnpm run build