Fix/agent skills reload#900
Merged
jaberjaber23 merged 2 commits intoRightNow-AI:mainfrom Mar 30, 2026
Merged
Conversation
The agent config reload logic was missing skills and mcp_servers from the change detection, so edits to these fields in agent.toml weren't being picked up when loading agents from SQLite. Added both fields to the comparison to ensure proper hot-reload.
The skills and mcp_servers fields must be at the top level of the agent.toml, not after [capabilities], due to TOML implicit table ordering rules.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
skillsandmcp_serversfrom the change detection, so edits to these fields inagent.tomlweren't being picked up when loading agents from SQLite.skillsandmcp_serversare correctly parsed from TOML.Root Cause
When the kernel loads agents from SQLite, it compares the disk config against the DB version to detect changes. However, the comparison list at
kernel.rs:1078-1092was missingskillsandmcp_serversfields.Additionally, discovered that
skillsandmcp_serversmust be at the top level of the agent.toml, not after[capabilities], due to TOML's implicit table ordering rules.Changes
kernel.rs: Added
skillsandmcp_serversto the comparison:integration_test.rs: Added test
test_agent_manifest_skills_parsingto verify TOML parsing works correctly.Correct agent.toml Format
NOT:
Testing
cargo clippy --workspace --all-targets -- -D warningspassescargo test --workspacepassesSecurity