Fix silent reinforcement: recognize [SILENT] token#877
Open
pbranchu wants to merge 5 commits intoRightNow-AI:mainfrom
Open
Fix silent reinforcement: recognize [SILENT] token#877pbranchu wants to merge 5 commits intoRightNow-AI:mainfrom
pbranchu wants to merge 5 commits intoRightNow-AI:mainfrom
Conversation
Member
|
Reviewed. Three issues before merge:
|
adc77ca to
e9f92d9
Compare
Extract is_silent_token() helper for case-insensitive [SILENT] detection. Revert unrelated Cargo.lock and formatting changes. Add unit tests. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
e9f92d9 to
946363e
Compare
The previous commit accidentally included a complete MCP module rewrite that removed Http transport and headers support, breaking compilation against upstream kernel.rs tests. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
nicseltzer
added a commit
to nicseltzer/openfang
that referenced
this pull request
Mar 29, 2026
Regenerated lockfile after cherry-picking 9 upstream PRs. Fixed needless borrow in line.rs introduced by PR RightNow-AI#877 formatting. Confidence: high Scope-risk: narrow
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
[SILENT]and[silent]to the NO_REPLY detection conditions in both streaming and non-streaming agent loop paths[no reply needed]in history instead of the literal[SILENT]text, which would otherwise reinforce silence in future turnsTest plan
[SILENT]is not stored literally in session historyNO_REPLYtoken still works as before[[silent]]directive parsing still works as before🤖 Generated with Claude Code