This repository was archived by the owner on Jun 9, 2025. It is now read-only.
Sync two FFT managers so they agree for basic inputs#1
Open
ezheidtmann wants to merge 1 commit intomasterfrom
Open
Sync two FFT managers so they agree for basic inputs#1ezheidtmann wants to merge 1 commit intomasterfrom
ezheidtmann wants to merge 1 commit intomasterfrom
Conversation
ezheidtmann
force-pushed
the
fft-window-fix
branch
from
d33117d to
d4794e9
Compare
ezheidtmann
changed the title
Contributor
Author
|
Ready for review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I made the fftw version single-precision, but most of the change is to use a homebrew hamming window.
Some examples of hamming windows in the wild:
https://developer.apple.com/library/mac/documentation/Accelerate/Reference/vDSPRef/#//apple_ref/c/func/vDSP_hamm_window
http://docs.scipy.org/doc/numpy-1.10.0/reference/generated/numpy.hamming.html
https://en.wikipedia.org/wiki/Window_function#Hamming_window
http://www.mathworks.com/help/signal/ref/hamming.html
https://www.dsprelated.com/freebooks/sasp/Matlab_Hamming_Window.html