Repository navigation
feat(query_engine): implement DateBetween::toArrowExpression - #1844
Open
fengelniederhammer wants to merge 1 commit into
Open
fengelniederhammer wants to merge 1 commit into
fengelniederhammer wants to merge 1 commit into
Conversation
fengelniederhammer
requested review from
taepper
and
a balanced review from Copilot
November 18, 2026 10:09
Contributor
|
This is a preview of the changelog of the next release. If this branch is not up-to-date with the current main branch, the changelog may not be accurate. Rebase your branch on the main branch to get the most accurate changelog. Note that this might contain changes that are on main, but not yet released. Changelog: 0.17.6 (2026-11-18)FeaturesBug Fixes
|
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The new tests cover only projections, leaving the FilterNode path for intermediate dates and null exclusion under negation untested for both plain and indexed dates.
1 open issue
What changed in this PR
Implements Arrow evaluation of date .between(...) expressions, enabling their use on intermediate query results rather than only database tables.
Changes:
- Adds date-bound translation using Arrow
Date32Scalarvalues. - Extracts shared inclusive-range translation and reuses it for integer expressions.
- Adds projection tests for plain and indexed dates, including open bounds, inclusive endpoints, and null values.
| File | Description |
|---|---|
src/rhydb/query_engine/scalar_expressions/int_between.cpp |
Delegates Arrow translation to the shared helper. |
src/rhydb/query_engine/scalar_expressions/date_between.test.cpp |
Adds Arrow-backed date range scenarios. |
src/rhydb/query_engine/scalar_expressions/date_between.h |
Declares the Arrow translation override. |
src/rhydb/query_engine/scalar_expressions/date_between.cpp |
Converts date bounds to Arrow scalars and invokes the helper. |
src/rhydb/query_engine/scalar_expressions/between_arrow.h |
Declares the shared range-expression helper. |
src/rhydb/query_engine/scalar_expressions/between_arrow.cpp |
Implements inclusive comparisons and null-preserving unbounded behavior. |
Review effort: Balanced
| ARROW_PLAIN_DATE_BOUNDS_ARE_INCLUSIVE_SCENARIO, | ||
| ARROW_INDEXED_DATE_WITH_FROM_AND_TO_SCENARIO, | ||
| ARROW_INDEXED_DATE_WITH_FROM_SCENARIO, | ||
| ARROW_INDEXED_DATE_WITH_TO_SCENARIO |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

resolves #1821
Summary
Allows to evaluate a date
.between(...)operator on intermediate results (i.e. something that is not a table in the DB).PR Checklist