Repository navigation
feat(query_engine): implement IntBetween::toArrowExpression - #1841
Open
fengelniederhammer wants to merge 4 commits into
Open
fengelniederhammer wants to merge 4 commits into
fengelniederhammer wants to merge 4 commits into
Conversation
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The unbounded IntBetween branch lacks a direct Arrow unit test for values and validity bits before and after negation, leaving null-to-false regressions undetected.
1 open issue
What changed in this PR
Implements IntBetween::toArrowExpression so integer .between(...) filters can run on intermediate query results, addressing #1820.
Changes:
- Translates inclusive bounds into Arrow comparisons using 64-bit literals.
- Preserves null results for null inputs, including the unbounded case.
- Adds query tests for mapped columns, negation, open bounds, and values beyond the 32-bit range.
| File | Description |
|---|---|
src/rhydb/query_engine/scalar_expressions/int_between.test.cpp |
Adds Arrow-path scenarios for 32-bit and 64-bit integer columns. |
src/rhydb/query_engine/scalar_expressions/int_between.h |
Declares the Arrow-expression override. |
src/rhydb/query_engine/scalar_expressions/int_between.cpp |
Implements bound comparisons and null-preserving unbounded evaluation. |
Review effort: Balanced
… pushed into table scan
fengelniederhammer
requested review from
taepper
and
a balanced review from Copilot
November 18, 2026 09:18
fengelniederhammer
marked this pull request as ready for review
November 18, 2026 09:18
Contributor
|
This is a preview of the changelog of the next release. If this branch is not up-to-date with the current main branch, the changelog may not be accurate. Rebase your branch on the main branch to get the most accurate changelog. Note that this might contain changes that are on main, but not yet released. Changelog: 0.17.6 (2026-11-18)FeaturesBug Fixes
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


resolves #1820
Summary
Allows to evaluate an int
.between(...)operator on intermediate results (i.e. something that is not a table in the DB).PR Checklist