Fix support for Eigen 5 while keep compatibility with Eigen 3 - #33
Open
traversaro wants to merge 2 commits into
Open
Fix support for Eigen 5 while keep compatibility with Eigen 3#33traversaro wants to merge 2 commits into
traversaro wants to merge 2 commits into
Conversation
3 tasks
Contributor
|
Hello, and sorry for the big lag It appear there are missing trailing #, as in: if defined(EIGEN_VERSION_AT_LEAST) && EIGEN_VERSION_AT_LEAST(5, 0, 0)Should be: #if defined(EIGEN_VERSION_AT_LEAST) && EIGEN_VERSION_AT_LEAST(5, 0, 0) |
Contributor
Author
Thanks, fixed in e549749 . |
Contributor
|
Look like there are two such problems (you only fixed one file) |
Contributor
Author
Sorry, in this case the slop was due to human editing, not AI! |
Contributor
|
No problem, don't forget to push your fix and I'll check everything works 🙂 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The main difference is that now
Eigen::allisEigen::placeholders::all.