15 UI migration compose - #23
Merged
Merged
Conversation
- Remove `BaseFragment`, `LoginFragment`, and sub-component fragments (`LoginEmailFragment`, `LoginPasswordFragment`, `LoginButtonFragment`) along with their associated XML DataBinding layouts. - Implement `LoginScreen` and modular UI components (`LoginEmailField`, `LoginPasswordField`, `LoginButton`) using Jetpack Compose and Material3. - Refactor `LoginViewModel` to use Compose `mutableStateOf` for `email` and `password` tracking. - Centralize input validation debouncing logic (300ms) within the `LoginViewModel` using `viewModelScope` to replace fragment-level handling. - Update `LoginViewModel` to handle pure state-driven UI updates, ensuring unidirectional data flow between the ViewModel and Composables. Signed-off-by: Alexis Tercero <alexistercero55@gmail.com>
- Replace Fragment-based architecture and XML layouts with the `HomeScreen` composable. - Remove legacy `HomeFragment`, `HomeServicesFragment`, `PageHeaderFragment`, and `PageFooterFragment` along with their associated layout files. - Implement modular UI components using Jetpack Compose: `PageHeader`, `PageFooter`, `ServiceList`, and `ServiceItem`. - Replace `RecyclerView` and `ServiceAdapter` with `LazyVerticalGrid` for displaying services. - Integrate `HomeViewModel` and `HeaderViewModel` state using `observeAsState` within the new composable hierarchy. Signed-off-by: Alexis Tercero <alexistercero55@gmail.com>
- Convert `MainActivity` from `AppCompatActivity` to `ComponentActivity` and replace XML layouts with `setContent`. - Remove `activity_main.xml` and `nav_graph.xml`, migrating navigation logic to a Compose-based `NavHost`. - Implement routing using `LaunchedEffect` to reactively navigate between `LoginScreen` and `HomeScreen` based on authentication state. - Replace fragment-based UI with `LoginScreen` and `HomeScreen` composables. - Introduce `LoadingScreen` and `LoadingOverlay` composables to manage UI state during session initialization and background processing. - Clean up View-based dependencies including Data Binding and `NavHostFragment`. Signed-off-by: Alexis Tercero <alexistercero55@gmail.com>
AlexisTercero55
added this to the
Jetpack compose development first (migration) milestone
AlexisTercero55
requested review from
MarkParedes,
alexistercero-rho-dev and
guslg325
July 30, 2026 00:32
AlexisTercero55
added
Auth-feature
AlexisTercero55
added
Navigation
This was
linked to
issues
Jul 30, 2026
Closed
Closed
alexistercero-rho-dev
approved these changes
Jul 30, 2026
alexistercero-rho-dev
left a comment
alexistercero-rho-dev
left a comment
Collaborator
There was a problem hiding this comment.
Build and application test on emulator
2026-07-30.11-01-23.mp4
github-project-automation
Bot
moved this from In progress
to Done
in UI-Rho-Studio-Components
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implementation of UI migration plan from Android View System to Jetpack compose
MIGRATION | #18 #20 login feature from Fragments to Jetpack Compose
BaseFragment,LoginFragment, and sub-component fragments (LoginEmailFragment,LoginPasswordFragment,LoginButtonFragment) along with their associated XML DataBinding layouts.LoginScreenand modular UI components (LoginEmailField,LoginPasswordField,LoginButton) using Jetpack Compose and Material3.LoginViewModelto use ComposemutableStateOfforemailandpasswordtracking.LoginViewModelusingviewModelScopeto replace fragment-level handling.LoginViewModelto handle pure state-driven UI updates, ensuring unidirectional data flow between the ViewModel and Composables.MIGRATION | #21 Home feature to Jetpack Compose
HomeScreencomposable.HomeFragment,HomeServicesFragment,PageHeaderFragment, andPageFooterFragmentalong with their associated layout files.PageHeader,PageFooter,ServiceList, andServiceItem.RecyclerViewandServiceAdapterwithLazyVerticalGridfor displaying services.HomeViewModelandHeaderViewModelstate usingobserveAsStatewithin the new composable hierarchy.MIGRATION | #22 MainActivity to Jetpack Compose and Compose Navigation
MainActivityfromAppCompatActivitytoComponentActivityand replace XML layouts withsetContent.activity_main.xmlandnav_graph.xml, migrating navigation logic to a Compose-basedNavHost.LaunchedEffectto reactively navigate betweenLoginScreenandHomeScreenbased on authentication state.LoginScreenandHomeScreencomposables.LoadingScreenandLoadingOverlaycomposables to manage UI state during session initialization and background processing.NavHostFragment.This PR would
fix #18
fix #20
fix #21
fix #22