docs(config): document the layered config model + add change-config s…#31
Merged
Conversation
…kill Rewrite docs/configuration.md around the five config layers (typed structs → field registry → disk → load/merge → runtime atomics mirror), with reload triggers and precedence rules. Add the missing [update] table, goblin_mode, agent/plugin color, plugin icon, and the gemini kind; complete field-reference tables matching the registry. Fix default_period allowed values (all/7d/30d, not today/this_month/all_time). Add .agent/skills/add-or-change-config.md: a developer how-to for adding or changing a config field, keyed to the anti-drift registry test and the runtime-mirror wiring, referencing the configuration doc.
Decouple the modal's content-fit auto-resize from window_chrome via a new `display.auto_resize: Option<bool>` (None ⇒ true). The auto-fit now follows this flag in app.rs instead of `!window_chrome`, so it works the same with or without the native title bar — preserving the chromeless behaviour and replicating it under chrome. window_chrome reverts to controlling only the title bar / decorations (no is_resizable or decoration coupling beyond the original). Fix a Windows-only invisibility bug exposed by the decoupling: the DWM cloak is un-cloaked only by the auto-fit callback, so it must track auto_resize, not !window_chrome — otherwise a chromeless + fixed-size window (auto_resize = false) would stay cloaked forever. Register the field across the self-documenting config surface (describe/get/set/toml + tests) and document it in configuration.md.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…kill
Rewrite docs/configuration.md around the five config layers (typed structs → field registry → disk → load/merge → runtime atomics mirror), with reload triggers and precedence rules. Add the missing [update] table, goblin_mode, agent/plugin color, plugin icon, and the gemini kind; complete field-reference tables matching the registry. Fix default_period allowed values (all/7d/30d, not today/this_month/all_time).
Add .agent/skills/add-or-change-config.md: a developer how-to for adding or changing a config field, keyed to the anti-drift registry test and the runtime-mirror wiring, referencing the configuration doc.