test: cover health dependency-graph aggregation#360
Merged
thlpkee20-wq merged 1 commit intoMay 27, 2026
Merged
Conversation
- Add tests for Horizon down + DB up → 503 unhealthy - Add tests for all-degraded combination → 200 degraded - Add test for DB checker throwing exception → 503 unhealthy - Add tests asserting latencyMs populated on both checks - Add test asserting dependsOn populated on database check - Add test for both DB and Horizon down → 503 unhealthy Fix healthRootHandler to catch unexpected checker exceptions (returns 503 instead of hanging on unhandled async rejection in Express 4). Fix exported createError() in errors.ts which was discarding the details argument, causing toResponse() to return details: true. Fix flaky duration assertion (toBeGreaterThan(0) → toBeGreaterThanOrEqual(0)) since synchronous mocks resolve in 0ms. Closes RevoraOrg#357
|
@omolobamoyinoluwa-max Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #357
Expands
src/routes/health.test.tsto fully exercise theHealthDependencyGraphaggregation logic across all dependency status combinations.New tests added
databaseandstellar-horizonchecksdatabasecheck when pool metrics presentBug fixes
src/routes/health.tshealthRootHandlerin try/catch — Express 4 does not auto-catch async rejections, causing the handler to hang whendbHealth()throwssrc/lib/errors.tscreateError()which was passingoptions?.expose !== falseas thedetailsargument, causingtoResponse()to returndetails: trueinstead of the actual details objectsrc/routes/health.test.tstoBeGreaterThan(0)→toBeGreaterThanOrEqual(0)for duration metric — synchronous mocks resolve in 0msTest results