-
Notifications
You must be signed in to change notification settings - Fork 21
Improve README: explain chapters concept, add prerequisites & troubleshooting #71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
ringku1
wants to merge
1
commit into
ReviewStage:main
Choose a base branch
from
ringku1:ringku1-improve-readme
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+31
−0
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -25,6 +25,17 @@ | |||||
| <a href="https://github.com/ReviewStage/stage-cli/blob/main/LICENSE"><img src="https://img.shields.io/npm/l/stagereview.svg" alt="license"></a> | ||||||
| </p> | ||||||
|
|
||||||
| ## What's a chapter? | ||||||
|
|
||||||
| Instead of reviewing a pull request as one long, undifferentiated diff, Stage groups related changes into "chapters" — for example, one chapter for a new API integration, another for a schema migration, another for test cleanup. Each chapter comes with a short summary of what changed and what's actually risky, so you know where to focus before reading line by line. | ||||||
|
|
||||||
| ## Prerequisites | ||||||
|
|
||||||
| - Node.js 18 or later | ||||||
| - A local git repository with changes to review | ||||||
| - An AI coding agent that supports the `skills` convention (see [Which agents work with this?](#which-agents-work-with-this)) | ||||||
| - Optional: the [GitHub CLI](https://cli.github.com/) (`gh`), only needed for `--pr` to review a pull request by number or URL | ||||||
|
|
||||||
| ## Install | ||||||
|
|
||||||
| ```bash | ||||||
|
|
@@ -100,6 +111,26 @@ dist/** | |||||
|
|
||||||
| Ignored files still appear in the "Other changes" chapter so nothing is silently hidden. Comments (`#`), blank lines, and negation patterns (`!`) are supported — last matching pattern wins. | ||||||
|
|
||||||
| ## Troubleshooting | ||||||
|
|
||||||
| **`/stage-chapters` isn't recognized in my agent.** | ||||||
| Re-run `npx skills add ReviewStage/stage-cli` to confirm it installed cleanly, and restart your agent — most agents only pick up newly registered skills after a restart. | ||||||
|
|
||||||
| **Stage says there's nothing to review.** | ||||||
| By default it looks for staged, unstaged, and untracked changes. If everything's already committed, use `--ref staged` or diff against a specific commit with `--compare`. | ||||||
|
|
||||||
| **It picked the wrong base branch.** | ||||||
| Auto-detection looks for `main` or `master`. If your default branch is named differently, pass it explicitly: `--base your-branch-name`. | ||||||
|
|
||||||
| **`--pr` isn't working.** | ||||||
| This requires the [GitHub CLI](https://cli.github.com/) installed and authenticated (`gh auth login`). Confirm `gh` works on its own first — Stage relies on it to fetch PR data. | ||||||
|
|
||||||
| ## Which agents work with this? | ||||||
|
|
||||||
| Stage runs on the `skills` convention for AI coding agents, so support depends on whether your agent implements that convention. If `npx skills add` doesn't complete, or `/stage-chapters` doesn't show up as a command afterward, check your agent's own docs for skills or plugin support. | ||||||
|
|
||||||
| *(Note to the Stage team: this is the one thing I couldn't verify from outside the project — worth explicitly listing which agents you've tested against, since "works with any AI agent" is the first thing a new user will want confirmed.)* | ||||||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. P2: Public README contains an internal editorial note addressed to the maintainers rather than end users. Prompt for AI agents
Suggested change
|
||||||
|
|
||||||
| <img width="1840" height="1196" alt="Stage CLI" src="https://raw.githubusercontent.com/ReviewStage/stage-cli/main/assets/screenshot.png" /> | ||||||
|
|
||||||
| ## License | ||||||
|
|
||||||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
P1: Troubleshooting gives incorrect recovery advice:
--ref stagedwill produce an empty diff when everything is already committed, and mischaracterizes the default diff scope as always scanning the working tree rather than auto-detecting between working-tree and committed modes.Prompt for AI agents