Repository navigation
feat(experiments): add read commands and development API routes - #179
Open
joshdholtz wants to merge 7 commits into
Open
joshdholtz wants to merge 7 commits into
joshdholtz wants to merge 7 commits into
Conversation
joshdholtz
added this pull request to stack #182
September 25, 2026 14:26
This was referenced Sep 25, 2026
joshdholtz
force-pushed
the
feat/experiments-read
branch
from
September 28, 2026 17:52
8bcff62 to
9aa0229
Compare
joshdholtz
marked this pull request as ready for review
September 28, 2026 17:56
JZDesign
reviewed
Sep 29, 2026
JZDesign
reviewed
Oct 6, 2026
JZDesign
approved these changes
Oct 7, 2026
JZDesign
approved these changes
Oct 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Expose the existing development v2 experiment reads to humans and agents. The endpoints stay in the development OpenAPI overlay.
First PR in the stack: #179 → #180 → #181.
Changes
rc experiments list|show|results.show.--json.Review note
The shared table-width fix measures visible Unicode width. It also changes spacing in existing app-list snapshots and previews; those files are included so the output stays aligned.
Verification
go test ./...,go vet ./...,make gen, andmake previewpassed locally after rebasing onto current main.Note
Medium Risk
Read-only API surface, but touches shared CLI output formatting and permission-sensitive show fallback; development-gated endpoints may differ from production behavior.
Overview
Adds read-only
rc experiments list|show|resultsagainst development v2 experiment endpoints, wired through a newExperimentsServiceand registered on the normal CLI surface (with overlay/coverage docs updated).showrenders variants (up to four offerings), audience/targeting, placements, setup, and a chronological timeline; it prefersexpand=offering.paywalland falls back to a plain GET with a warning when offerings read is forbidden.resultsprints total-segment metric tables, chance-to-win / lift intervals, and predicted LTV in human mode, with full sections/segments in--json; filters normalize platform aliases and country/currency casing, validateexposure-status, and warn on unknown platforms.Also fixes table/card padding to use Unicode display width (
lipgloss.Width), which updates a few existing app-list snapshots; snapshot harness now runs root with a shared stdout/stderr writer for stable ordering.Reviewed by Cursor Bugbot for commit b44495e. Bugbot is set up for automated code reviews on this repo. Configure here.