Skip to content

init#9

Open
gee92 wants to merge 5 commits into
Return-Ready-2021-JavaScript-Evening:mainfrom
gee92:main
Open

init#9
gee92 wants to merge 5 commits into
Return-Ready-2021-JavaScript-Evening:mainfrom
gee92:main

Conversation

@gee92
Copy link
Copy Markdown

@gee92 gee92 commented Oct 31, 2020

No description provided.

@kburd kburd self-requested a review November 5, 2020 18:58
Comment thread resume.html
<body>

<h1>Geneara Boardley</h1>
<img src="IMG_2333.jpeg" alt="geneara work picture" width="350" height="250">
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing image file (-2)

Comment thread resume.html


</body>
</html> No newline at end of file
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor formatting issues (-1)

Comment thread resumeform.html
<label for="contactphonenumber"> Contact Phone Number></label>
<input type="text" id="contactphonenumber" name="contactphonenumber" maxlength="50"><br>


Copy link
Copy Markdown

@kburd kburd Nov 5, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

99/100

@gee92
Copy link
Copy Markdown
Author

gee92 commented Nov 5, 2020 via email

Comment thread resumeform.html

<label> Phone Number Type</label>
<input type="radio" name="Phonenumbertype" value="landline" maxlength="10"><label>Landline</label>

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need for the maxlength here

@kburd
Copy link
Copy Markdown

kburd commented Nov 5, 2020

99/100

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants