Skip to content

correct lab#10

Open
DBenson05 wants to merge 1 commit into
Return-Ready-2021-JavaScript-Evening:mainfrom
DBenson05:main
Open

correct lab#10
DBenson05 wants to merge 1 commit into
Return-Ready-2021-JavaScript-Evening:mainfrom
DBenson05:main

Conversation

@DBenson05
Copy link
Copy Markdown

No description provided.

@kburd kburd self-requested a review November 12, 2020 15:46
Comment thread forms.html
<style>

</style>
<span class="border border-dark" .m1></span>
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Empty span can be deleted

Comment thread portfolio.html
<html>
<header><tittle>Resume</tittle></header>

<img src="C:\Users\user\Pictures\resumephoto.jpg" style="width: 20%; height: 20%;" alt="Resume Photo"><br>
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing image file (-2)
Path is absolute (-1)

Comment thread portfolio.html

<body>
<head>
<h2>DaRon Benson</h2>
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(-1) Your headers are assigned incorrectly. The headers should trend upwards as the info becomes less relevant. For example:
<h1>DaRon Benson
<h2>Experience
<h3>Mixer

Comment thread portfolio.html

As manager of Illustrated Thoughts Entertainment
<br><ul>
<li>.Advise independent Musicians on the entertainment business.</li>
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need for the . at the beginning of each line

Comment thread portfolio.html
@@ -0,0 +1,59 @@
<!DOCTYPE html>
<html>
<header><tittle>Resume</tittle></header>
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be head here (-1)

Comment thread forms.html
<option value="Recruiter">Recruiter</option>
</select>
<label>interest For Contacting</label><br>
<input type="text" id="Interest for contacting" name="interestforcontacting"><br>
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Extra input

Comment thread forms.html
<input type="text" id="Interest for contacting" name="interestforcontacting"><br>


<label>Skill Set</label><br>
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Extra label, the "Interest for contacting" label should be for this input (-1)

Comment thread forms.html
<input type="checkbox" name="skillset1" value="manager"><label>Manager</label><br>
<input type="checkbox" name="skillset2" value="marketing"><label>Marketing</label><br>
<input type="checkbox" name="skillset3" value="webdesign"><label>Web Design </label><br>
</span>
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where is the opening tag?

Comment thread forms.html

</body>

</html> No newline at end of file
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing character limit on all fields (-3)
Missing Text Area (-5)

Comment thread forms.html
<span class="border border-dark" .m1></span>
<form>
<label for="name">First Name</label>
<input type="text" id="name" name="name"><div>
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need for the div here or below (-1)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants