Skip to content

Recognize SCPH5552 outputs and retain its SDK inputs - #5

Open
Alexbeav wants to merge 1 commit into
RetroPortingToolKit:mainfrom
Alexbeav:codex/scph5552-build-readiness-20260907
Open

Recognize SCPH5552 outputs and retain its SDK inputs#5
Alexbeav wants to merge 1 commit into
RetroPortingToolKit:mainfrom
Alexbeav:codex/scph5552-build-readiness-20260907

Conversation

@Alexbeav

@Alexbeav Alexbeav commented Sep 7, 2026

Copy link
Copy Markdown

SCPH5552 titles can finish generation and then stop because both build-readiness checks recognize only OpenBIOS and SCPH1001 output. The shared SDK harvest also drops the SCPH5552 profile and seed file. This change recognizes the existing backend and retains those two source inputs, while keeping the owned BIOS image out of the shared SDK.

Validation against unchanged upstream 99e0238f53356b63d966d9dfe6f0abaacc578d17:

  • Production-function fixture: 15 synthetic assertions pass after the correction. Four fail on the baseline. Existing OpenBIOS/SCPH1001 controls still pass; missing files, wrong suffixes, directory lookalikes and missing game output still fail readiness.
  • Two additional checks on a completed owned-input GITS setup fail before and pass after (17 total after, 6 failures before).
  • The full corrected Windows CLI builds, harvests its SDK, generates SCPH5552 and game output, compiles, installs and launches GITS from the exact setup kit. The installed game exits normally after window close, at frame 2232. This used a local source override and an existing portable toolchain; public download, hub UI, audio, visual and gameplay checks are outside this result.

Run the synthetic check with python scripts/test_psx_bios_readiness.py --cxx g++. Add --baseline-ref 99e0238f53356b63d966d9dfe6f0abaacc578d17 for the failing control. The fixtures contain no retail data. The patch preserves the title's selected BIOS policy.

Developed with AI assistance; validated as described (test evidence in PR body). AI writes the code and the PR, but I always test before I send something up. Happy to iterate on this process with your feedback.

@TechnicallyComputers

Copy link
Copy Markdown
Member

I don't know that we have 5552 support yet, and it needs handling in the generate & build and netplay lobby, and settings window for rebuild prompts, as well so I'll just leave this open for now.

@Alexbeav

Alexbeav commented Sep 10, 2026

Copy link
Copy Markdown
Author

Thanks for the review, and for pointing at the full 5552 surface. I agree the launcher needs more than build readiness before 5552 titles work end-to-end. A proposal to keep this mergeable without blocking your rollout:

  • Keep PR5 scoped to build readiness + SDK harvest. Those two checks currently reject finished 5552 generations, so they sit on every 5552 setup path no matter how the rest lands.
  • Netplay lobby and the settings rebuild prompts: untouched here, and I have no evidence for them. If you own the full 5552 rollout in-house, I can rebase this against your branch. Alternatively, tell me the expected settings rebuild behavior and I'll extend this PR with it.
  • The BIOS side has a matching upstream piece: bios: add SCPH5552 (EU v3.0 01/06/97) BIOS build profile psxrecomp#243 (SCPH5552 build profile). The catalog submission (Bulk submission: 26 Wave 3 PlayStation setup titles Retro-Catalog#37) already discloses the launcher dependency.

Scope evidence: 15 synthetic assertions pass (4 fail on baseline 99e0238f), existing OpenBIOS/SCPH1001 controls still pass, and the exact Windows CLI completes a GITS setup, build, install, launch and clean exit. Fixtures contain no retail data.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants