fix(api/v2): enforce a cap on number of leaderboard entries that can be returned - #5214
Open
wescopeland wants to merge 1 commit into
Open
fix(api/v2): enforce a cap on number of leaderboard entries that can be returned#5214wescopeland wants to merge 1 commit into
wescopeland wants to merge 1 commit into
Conversation
Contributor
Greptile SummaryAdds validation limiting leaderboard Confidence Score: 5/5Safe to merge. The validation follows existing query conventions and tests the intended rejection. Reviews (1): Last reviewed commit: "fix(api/v2): enforce a cap on number of ..." | Re-trigger Greptile |
Jamiras
reviewed
Sep 10, 2026
| public function rules(): array | ||
| { | ||
| return array_merge(parent::rules(), [ | ||
| 'filter.maxRank' => ['integer', 'min:1', 'max:100'], |
Member
There was a problem hiding this comment.
Is this really what you want to be restricting? If I query all my leaderboard-entries, there are quite a few where my rank is over 100:
"attributes": {
"score": 7250,
"formattedScore": "1:12.50",
"rank": 370,
"createdAt": "2019-03-02T16:30:10.000000Z",
"updatedAt": "2019-03-02T16:30:10.000000Z"
},
If you want to limit the number of returned values, you should restrict page[size], which (at least for this endpoint) defaults to 50.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently,
?filter[maxRank]has no maximum allowed value. This PR sets a cap at 100.