fix(ui): preserve controls during remote refresh - #121
Conversation
Update choice rows in place so metadata refreshes do not dismiss an open popover. Co-authored-by: Codex <codex@openai.com>
|
Warning Review limit reached
Next review available in: 18 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (5)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Keep client-only placeholder rows during daemon tree reconciliation so refreshes cannot discard active new-chat or new-folder input. Co-authored-by: Codex <codex@openai.com>
Keep the active node through remove-and-reinsert reconciliation and skip duplicate selection opens so background tree updates cannot steal focus. Co-authored-by: Codex <codex@openai.com>
Co-authored-by: Codex <codex@openai.com>
Cap popover height so repositories with many worktrees fit on screen instead of producing an oversized popup that is immediately dismissed. Co-authored-by: Codex <codex@openai.com>
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 3335358ceb
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| if (is_client_placeholder (node)) | ||
| g_ptr_array_insert (target, MIN (i, target->len), | ||
| g_steal_pointer (&node)); |
There was a problem hiding this comment.
Reconcile daemon rows without relocating placeholders
When a daemon snapshot adds, removes, or reorders a folder before an inline new-chat row, inserting the placeholder into target at its pre-refresh absolute index does not keep the row alive. Reconciliation first moves the changed daemon row, shifting the placeholder, and then the generic loop removes and reinserts the placeholder to restore this target index; GTK consequently unbinds the active editor, which can commit it through on_editor_focus_left() or discard its focus before the user submits or cancels. Preserve placeholders independently of daemon-row movement rather than assigning them an absolute target index.
Useful? React with 👍 / 👎.
| if (node == NULL || node == self->selected) | ||
| return; |
There was a problem hiding this comment.
Distinguish explicit unselection from reconciliation gaps
When the user explicitly clears the current selection, which is supported because this model enables can_unselect, this return leaves self->selected pointing at the old node. Reselecting that same row is then also suppressed by the identity check, so no node-selected signal is emitted and the pending restore_chat_id is not cleared; if a saved remote chat finishes loading afterward, restoration can unexpectedly replace the user's renewed selection. Ignore only the transient deselection caused by reconciliation, while recording genuine unselection.
Useful? React with 👍 / 👎.
Summary
Testing
./scripts/test.sh— 20/20 test suites passed