Add RFP Contribute CTA and funding-pool mode on contribute - #1095
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 60c082c583
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| ? (progressOverride?.goalAmountUsd ?? grantAmount?.usd ?? 0) | ||
| : (progressOverride?.goalAmountUsd ?? fundraise?.goalAmount?.usd ?? 0); | ||
| const remainingGoalUsd = Math.max(0, goalAmountUsd - currentAmountUsd); | ||
| const quickAmountCeilingUsd = isPoolMode && remainingGoalUsd <= 0 ? 10000 : remainingGoalUsd; |
There was a problem hiding this comment.
When an open funding pool has amountRaised.usd >= grantAmount.usd, this fallback keeps the unbounded quick-amount buttons available, but the still-rendered FundingImpactPreview receives the original fully met goal. Its drag calculation treats the remaining goal as zero and calls onAmountChange(0) for every slider interaction, clearing the contribution and disabling Continue. Give the pool preview an unbounded ceiling too, or stop rendering it once the displayed goal has been met.
Useful? React with 👍 / 👎.
…chHub/web into rfp-funding-pool-contribute
…Grant components; update ContributeToFundraiseModal to handle funding pool mode without grant amount.
…ub/web into rfp-funding-pool-contribute
|
1 participant
No description provided.