-
Notifications
You must be signed in to change notification settings - Fork 10
docs: update SDK quickstart and request update guide #134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: update SDK quickstart and request update guide #134
Conversation
WalkthroughTwo documentation files are updated to enhance Request Network SDK guides: the quickstart guide now includes a section on updating requests with code examples, and the dedicated updating-requests guide is restructured with a new actions summary table and comprehensive examples demonstrating initialization and request operations. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes 🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Hello @AllenAJ, thank you for submitting your first pull request to the docs.request.network repository. We value your contribution and encourage you to review our contribution guidelines to ensure your submission meets our standards. Please note that every merged PR is automatically enrolled in our Best PR Initiative, offering a chance to win $500 each quarter. Our team is available via GitHub Discussions or Discord if you have any questions. Welcome aboard! |
|
Thank you for your submission! As you prepare for the review process, please ensure that your PR title, description, and any linked issues fully comply with our contribution guidelines. A clear explanation of your changes and their context will help expedite the review process. Every merged PR is automatically entered into our Best PR Initiative, offering a chance to win $500 every quarter. We appreciate your attention to detail and look forward to reviewing your contribution! |
Greptile OverviewGreptile SummaryEnhanced SDK documentation by adding functional request update examples to both the Node.js quickstart and the detailed updating guide. The viem tab was clarified to direct Node.js users to ethers v5 instead of the browser-specific adapter patterns.
Issues Found:
Confidence Score: 3/5
Important Files Changed
Sequence DiagramsequenceDiagram
participant User
participant App
participant RequestClient
participant SignatureProvider
participant RequestNode
participant IPFS
Note over User,IPFS: Update Request Flow
User->>App: Initiate request update (e.g., accept, cancel)
App->>RequestClient: fromRequestId('REQUEST_ID')
RequestClient->>RequestNode: Fetch request data
RequestNode-->>RequestClient: Return request data
App->>RequestClient: request.accept(identity) / cancel() / etc.
RequestClient->>SignatureProvider: Sign update transaction
SignatureProvider-->>RequestClient: Return signature
RequestClient->>IPFS: Store updated request data
IPFS-->>RequestClient: Return IPFS CID
RequestClient->>RequestNode: Submit update with CID
RequestNode-->>RequestClient: Acknowledge update
App->>RequestClient: request.waitForConfirmation()
RequestClient->>RequestNode: Poll for confirmation
RequestNode-->>RequestClient: Confirmed
RequestClient-->>App: Updated request data
App-->>User: Update successful
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Additional Comments (4)
-
docs/advanced/request-network-sdk/get-started/quickstart-node.js.md, line 197-200 (link)logic: Uses
mainnetchain but the rest of the quickstart uses Sepolia. Should be consistent.Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!
-
docs/advanced/request-network-sdk/get-started/quickstart-node.js.md, line 205-207 (link)logic: Chain should match Sepolia for consistency with the rest of the quickstart.
Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!
-
docs/advanced/request-network-sdk/get-started/quickstart-node.js.md, line 211-213 (link)logic: Should use
sepoliainstead ofmainnetfor consistency.Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!
-
docs/advanced/request-network-sdk/get-started/quickstart-node.js.md, line 210-214 (link)logic: The viem
WalletClient.transportis not directly compatible with ethersWeb3Provider. Check the implementation inquickstart-browser.md:274-284which properly extracts account and chain info from thewalletClientbefore creating the provider.
5 files reviewed, 4 comments
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
📜 Review details
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (5)
docs/SUMMARY.mddocs/advanced/request-network-sdk/get-started/quickstart-node.js.mddocs/advanced/request-network-sdk/sdk-guides/request-client/updating-a-request.mddocs/faq.mddocs/general/advocates-welcome-kit.md
🧰 Additional context used
📓 Path-based instructions (1)
**/*
⚙️ CodeRabbit configuration file
**/*: - Only comment on issues that would block merging — ignore minor or stylistic concerns.
- Restrict feedback to errors, security risks, or functionality-breaking problems.
- Do not post comments on code style, formatting, or non-critical improvements.
- Keep reviews short: flag only issues that make the PR unsafe to merge.
- Limit review comments to 3–5 items maximum, unless additional blockers exist.
- Group similar issues into a single comment instead of posting multiple notes.
- Skip repetition — if a pattern repeats, mention it once at a summary level only.
- Do not add general suggestions; focus strictly on merge-blocking concerns.
- If there are no critical problems, respond with minimal approval (e.g., 'Looks good'). Do not add additional review.
- Avoid line-by-line commentary unless it highlights a critical bug or security hole.
- Highlight only issues that could cause runtime errors, data loss, or severe maintainability issues.
- Ignore minor optimization opportunities — focus solely on correctness and safety.
- Provide a top-level summary of critical blockers rather than detailed per-line notes.
- Comment only when the issue must be resolved before merge — otherwise, remain silent.
- When in doubt, err on the side of fewer comments — brevity and blocking issues only.
- Avoid posting any refactoring issues
Files:
docs/advanced/request-network-sdk/get-started/quickstart-node.js.mddocs/general/advocates-welcome-kit.mddocs/SUMMARY.mddocs/faq.mddocs/advanced/request-network-sdk/sdk-guides/request-client/updating-a-request.md
🪛 LanguageTool
docs/general/advocates-welcome-kit.md
[style] ~20-~20: The noun “invitation” is usually used instead of ‘invite’ in formal writing.
Context: ...ols * Notion: You will receive an invite to our private Advocates workspace. * ...
(AN_INVITE)
🪛 markdownlint-cli2 (0.18.1)
docs/general/advocates-welcome-kit.md
47-47: Bare URL used
(MD034, no-bare-urls)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: Greptile Review
docs/advanced/request-network-sdk/get-started/quickstart-node.js.md
Outdated
Show resolved
Hide resolved
|
Regarding the Greptile feedback about | **addStakeholders** | Grant 1 or more third parties access to view an encrypted request | Payee, Payer, or Third Party |We'll add this back in a follow-up commit. |
- Replace broken viem-to-ethers code in Node.js quickstart with note explaining that viem http() transport isn't EIP-1193 compatible - Restore addStakeholders row to updating-a-request.md table Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
|
I've pushed a fix commit (087dc01) to your branch that:
The rest of the PR looks good - the Advocates Welcome Kit and the Update a Request examples are helpful additions. Thanks for the contribution! |
Change Discord link from discord.gg/request to request.network/discord to match existing docs pattern. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Remove advocates-welcome-kit.md and related navigation entries. Program details will be maintained elsewhere. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
|
@greptileai review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
2 files reviewed, 6 comments
docs/advanced/request-network-sdk/get-started/quickstart-node.js.md
Outdated
Show resolved
Hide resolved
docs/advanced/request-network-sdk/sdk-guides/request-client/updating-a-request.md
Outdated
Show resolved
Hide resolved
docs/advanced/request-network-sdk/sdk-guides/request-client/updating-a-request.md
Outdated
Show resolved
Hide resolved
docs/advanced/request-network-sdk/sdk-guides/request-client/updating-a-request.md
Outdated
Show resolved
Hide resolved
docs/advanced/request-network-sdk/sdk-guides/request-client/updating-a-request.md
Outdated
Show resolved
Hide resolved
docs/advanced/request-network-sdk/sdk-guides/request-client/updating-a-request.md
Show resolved
Hide resolved
|
Fixed. Changed to This aligns with the established pattern in the SDK API reference ( |
- Changed payerAddress/signerAddress/payeeAddress to *Identity in updating-a-request.md - Fixed repo URL typo: quickstart-node.js -> quickstart-node-js
|
Congratulations, your pull request has been merged! Thank you for your valuable contribution to Request Network. As a reminder, every merged PR is automatically entered into our Best PR Initiative, offering a quarterly prize of $500. Your work significantly supports our project's growth, and we encourage you to continue engaging with our community. Additionally, if you want to build or add crypto payments and invoicing features, explore how our API can reduce deployment time from months to hours while offering advanced features. Book a call with our expert to learn more and fast-track your development. |
Maintainer Changes
The following modifications were made during review:
addStakeholdersrow in updating-a-request.md tablerequest.network/discord)*Identitynaming convention - ChangedpayerAddress/signerAddress/payeeAddresstopayerIdentity/signerIdentity/payeeIdentityin IIdentity object examples. This aligns with the SDK's semantic distinction:*Identityfor signing/access control,*Addressfor payment routing.quickstart-node.jstoquickstart-node-jsSummary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.