Skip to content

fix(certificates): hide completed operations from table - #121

Merged
RentnerKev merged 1 commit into
mainfrom
fix/completed-certificate-operation-display
Sep 17, 2026
Merged

RentnerKev merged 1 commit into
mainfrom
fix/completed-certificate-operation-display

Conversation

@RentnerKev

Copy link
Copy Markdown
Owner

Closes #114

Summary

  • treat an idle certificate's completed Applied operation as historical in the table view model
  • keep active, retry-scheduled, failed, and needs-attention states visible
  • preserve completed operation metadata in certificate details while re-enabling normal actions
  • align table search with the visible current-operation state

Verification

  • bun --env-file=../../.env run --bun check
  • 703 Bun tests passed; 175 Rust tests passed

@github-actions github-actions Bot added area: certificates Certificates, ACME, trusted CAs, and TLS material. area: ui Web interface components, routes, styling, and localization. labels Sep 17, 2026
@coderabbitai

coderabbitai Bot commented Sep 17, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

Next included review available in 29 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Advanced

Run ID: 104d1d5c-4f86-4319-a6e2-5c041b27c849

📥 Commits

Reviewing files that changed from the base of the PR and between 33c95ff and b434456.

📒 Files selected for processing (3)
  • web/src/features/Admin/CertificateManagement/Helpers/certificateOperations.ts
  • web/src/tests/certificate-operations.test.ts
  • web/src/tests/certificates-ui.test.tsx

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions

Copy link
Copy Markdown

🐳 RentnerProxy PR Preview

A test-only image for this pull request has been published successfully.

Images

Type Image
Moving preview for this PR ghcr.io/rentnerkev/rentnerproxy:pr-121
Exact tested build ghcr.io/rentnerkev/rentnerproxy:pr-121-49a901bfb0bd

Image digest: sha256:94fe078622c8455a213bde0acd7f7e9c4d8f375f6b2726d6cb0d309beeedd87e

Tested and built merge commit: 49a901bfb0bd0c1d07af224c65de3e39263f4126

Pull request head commit: b434456ee66fe4df33cec915b1f8d8f62f54ecd9

For reproducible testing and bug reports, prefer pr-121-49a901bfb0bd. The pr-121 tag moves to the newest successful preview for this PR.


⚠️ Unreviewed development preview

This image contains unreviewed pull-request code. It may contain bugs, breaking changes, incomplete or incompatible migrations, configuration errors, and changes that damage data or runtime state.

Do not use this PR preview image with production data.

Before testing:

  1. Back up PostgreSQL.
  2. Back up the complete RentnerProxy controller/runtime state in /var/lib/rentnerproxy, including certificates, private keys, ACME state, active configuration, last-known-good state, and trusted CA material.
  3. Prefer a separate test database and separate Docker volumes.
  4. Use an isolated Docker Compose project and avoid production port bindings.

Docker

docker pull ghcr.io/rentnerkev/rentnerproxy:pr-121-49a901bfb0bd

Docker Compose

In a separate test copy of docker-compose.yml, replace the service image with:

image: ghcr.io/rentnerkev/rentnerproxy:pr-121-49a901bfb0bd

Then use an isolated Compose project:

docker compose --project-name rentnerproxy-pr-121 pull
docker compose --project-name rentnerproxy-pr-121 up -d

The repository Compose file binds ports 80, 81, and 443; change those bindings or stop the production stack before testing.

This preview is intended only for testing this pull request and is not a production release.

@RentnerKev
RentnerKev merged commit 6d417a3 into main Sep 17, 2026
19 checks passed
@RentnerKev
RentnerKev deleted the fix/completed-certificate-operation-display branch September 17, 2026 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: certificates Certificates, ACME, trusted CAs, and TLS material. area: ui Web interface components, routes, styling, and localization.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fix(certificates): simplify completed operation presentation

1 participant