Skip to content

feat(ui): open managed domains in new tabs - #120

Merged
RentnerKev merged 3 commits into
mainfrom
feat/clickable-managed-domains
Sep 17, 2026
Merged

RentnerKev merged 3 commits into
mainfrom
feat/clickable-managed-domains

Conversation

@RentnerKev

Copy link
Copy Markdown
Owner

Closes #113

Summary

  • open concrete Proxy Host, Certificate, and Redirect Host domains over HTTPS in a new tab
  • keep wildcard entries display-only while making hidden SANs independently accessible
  • isolate pointer and keyboard interaction from surrounding row actions

Verification

  • bun --env-file=../../.env run --bun check

@coderabbitai

coderabbitai Bot commented Sep 17, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

Next included review available in 15 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Advanced

Run ID: f6174cff-9643-49ff-bb49-86b094a4eddd

📥 Commits

Reviewing files that changed from the base of the PR and between 33c95ff and ddf335c.

📒 Files selected for processing (14)
  • web/src/features/Admin/CertificateManagement/Components/CertificateTableCells.tsx
  • web/src/features/Admin/ProxyHostManagement/Components/ProxyHostTableCells.tsx
  • web/src/features/Admin/RedirectHostManagement/Components/RedirectHostTableCells.tsx
  • web/src/language/Locales/de.json
  • web/src/language/Locales/en.json
  • web/src/language/Locales/es.json
  • web/src/language/Locales/fr.json
  • web/src/shared/Domain/ManagedDomainLink.tsx
  • web/src/shared/Domain/ManagedDomainOverflow.tsx
  • web/src/shared/Domain/index.ts
  • web/src/shared/Domain/managedDomain.ts
  • web/src/tests/certificates-ui.test.tsx
  • web/src/tests/managed-domain-links.test.tsx
  • web/src/tests/proxy-hosts-ui.test.tsx

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions github-actions Bot added area: proxy Proxy host configuration and request forwarding. area: certificates Certificates, ACME, trusted CAs, and TLS material. area: ui Web interface components, routes, styling, and localization. labels Sep 17, 2026
Comment thread web/src/tests/proxy-hosts-ui.test.tsx Fixed
@github-actions

Copy link
Copy Markdown

🐳 RentnerProxy PR Preview

A test-only image for this pull request has been published successfully.

Images

Type Image
Moving preview for this PR ghcr.io/rentnerkev/rentnerproxy:pr-120
Exact tested build ghcr.io/rentnerkev/rentnerproxy:pr-120-5d072eb3be54

Image digest: sha256:053565a1fa283865d0837bad6e8dcc4332dcb1c75dc30a0c4a4d173639dee2d2

Tested and built merge commit: 5d072eb3be543b14e9294145509e32b0356a8390

Pull request head commit: ddf335c0a64dd665e9cabfa0b160e65790c33ffd

For reproducible testing and bug reports, prefer pr-120-5d072eb3be54. The pr-120 tag moves to the newest successful preview for this PR.


⚠️ Unreviewed development preview

This image contains unreviewed pull-request code. It may contain bugs, breaking changes, incomplete or incompatible migrations, configuration errors, and changes that damage data or runtime state.

Do not use this PR preview image with production data.

Before testing:

  1. Back up PostgreSQL.
  2. Back up the complete RentnerProxy controller/runtime state in /var/lib/rentnerproxy, including certificates, private keys, ACME state, active configuration, last-known-good state, and trusted CA material.
  3. Prefer a separate test database and separate Docker volumes.
  4. Use an isolated Docker Compose project and avoid production port bindings.

Docker

docker pull ghcr.io/rentnerkev/rentnerproxy:pr-120-5d072eb3be54

Docker Compose

In a separate test copy of docker-compose.yml, replace the service image with:

image: ghcr.io/rentnerkev/rentnerproxy:pr-120-5d072eb3be54

Then use an isolated Compose project:

docker compose --project-name rentnerproxy-pr-120 pull
docker compose --project-name rentnerproxy-pr-120 up -d

The repository Compose file binds ports 80, 81, and 443; change those bindings or stop the production stack before testing.

This preview is intended only for testing this pull request and is not a production release.

@RentnerKev
RentnerKev merged commit 7e1e7bb into main Sep 17, 2026
19 checks passed
@RentnerKev
RentnerKev deleted the feat/clickable-managed-domains branch September 17, 2026 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: certificates Certificates, ACME, trusted CAs, and TLS material. area: proxy Proxy host configuration and request forwarding. area: ui Web interface components, routes, styling, and localization.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feat(ui): open managed domains in a new browser tab

2 participants