fix(ui): align host configuration with global editor - #109
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (2)
🚧 Files skipped from review as they are similar to previous changes (2)
Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review. 📝 WalkthroughWalkthroughThe proxy host configuration editor now exposes only edit and active views. It removes preview, defaults, reload, and related state. The active configuration uses formatted syntax rendering. Tests cover the updated controls and reset flow. ChangesHost editor alignment
Priority: ➖ Normal Estimated code review effort: 3 (Moderate) | ~20 minutes Change: Bug fix · Severity of issue fixed: Low Merge Risk: ⚪ Minimal · up to The editor alignment change has no identified current-head defect requiring resolution before merge. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
🐳 RentnerProxy PR PreviewA test-only image for this pull request has been published successfully. Images
Image digest: Tested and built merge commit: Pull request head commit: For reproducible testing and bug reports, prefer
|
|
🤖 Completed: Fix pre-merge checks in PR #109 — View commit |
The per-host Caddy configuration dialog still exposed Preview, Generated defaults and Reload, and displayed active configuration as plain text. It now matches the global editor with Settings and Active config, using the same formatted, syntax-highlighted CaddyConfigCodeBlock.
Removed obsolete preview/reload state and handlers from the host editor. Host-specific settings, revision-aware saves, toast feedback, the disabled-host notice, and confirmed reset behavior remain intact. The host dialog continues to expose only the four supported host overrides.
Closes #108
Validation: focused proxy-host UI tests pass (38 tests), including new formatting/obsolete-controls and reset-confirmation regressions. The full bun run check passed: formatting, lint, TypeScript, migration checks, 696 web tests (124 environment-dependent tests skipped), Cargo check/Clippy/tests, and web/controller production builds.
Summary by CodeRabbit