Skip to content

fix: keep plugin root pointed at checkout#57

Merged
yyiilluu merged 1 commit into
mainfrom
codex/migrate-codex-settings-pr
May 24, 2026
Merged

fix: keep plugin root pointed at checkout#57
yyiilluu merged 1 commit into
mainfrom
codex/migrate-codex-settings-pr

Conversation

@yyiilluu
Copy link
Copy Markdown
Contributor

@yyiilluu yyiilluu commented May 24, 2026

Summary

  • Keep the claude-smart local setup script pointing ~/.reflexio/plugin-root back at the editable checkout after Codex setup rewrites it to the cache.
  • This keeps Claude Code slash commands and CLI shims resolving to the live working tree after combined Claude/Codex setup runs.

Changes

  • Move the plugin-root reset to the end of setup-local-dev.sh so it always runs after optional Codex installation.
  • Replace the conditional Claude+Codex-only reset with an unconditional final reset and explanatory comments.

Test Plan

  • Not run; shell script behavior change only, reviewed diff for setup ordering.

Summary by CodeRabbit

  • Chores
    • Improved local development setup script to ensure consistent plugin path configuration.

Review Change Stack

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 24, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: c85590a8-883e-47bd-9ede-30bb6f8aa8df

📥 Commits

Reviewing files that changed from the base of the PR and between a79f04c and 8e8b5ae.

📒 Files selected for processing (1)
  • scripts/setup-local-dev.sh

📝 Walkthrough

Walkthrough

The script now defers forcing ~/.reflexio/plugin-root to the editable checkout until an unconditional block at the end, rather than immediately after Claude Code setup. This ensures Codex's link rewriting is overridden consistently so later slash-command and CLI shim resolution targets the live working tree.

Changes

Plugin Root Resolution Timing

Layer / File(s) Summary
Defer plugin-root symlink override to end of script
scripts/setup-local-dev.sh
The earlier forced ~/.reflexio/plugin-root update after Claude Code setup is removed, and an unconditional end-of-script block now calls force_plugin_root_to_checkout to repoint the symlink after all Codex setup work completes, ensuring consistent override of Codex's link rewriting.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Possibly related PRs

  • ReflexioAI/claude-smart#52: Both PRs modify scripts/setup-local-dev.sh's ~/.reflexio/plugin-root force/restore behavior—changing when and how it's repointed back to the editable checkout after Codex/Claude Code setup.
  • ReflexioAI/claude-smart#11: Both PRs ensure ~/.reflexio/plugin-root points to the live repo so slash-command routing via plugin/scripts/cli.sh works correctly during local setup.

Poem

🐰 A symlink in time, now deferred with care,
No early override cluttering the air,
Wait till Codex completes its dance,
Then claim the plugin—a second chance!
The checkout glows at path's end station.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: deferring and ensuring the plugin-root symlink points at the checkout throughout the setup process.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch codex/migrate-codex-settings-pr

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@yyiilluu yyiilluu merged commit 12759ea into main May 24, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant