bazaar: fix churn_error event kwarg collision that killed churn workers#7
Open
raz-mon wants to merge 3 commits into
Open
bazaar: fix churn_error event kwarg collision that killed churn workers#7raz-mon wants to merge 3 commits into
raz-mon wants to merge 3 commits into
Conversation
stats.event("churn_error", op=op, ...) passed op twice (positional event
name + kwarg) -> TypeError -> all 8 churn workers died on their first op
error. Rename the field to failed_op. Surfaced by incident 3, when the
wedged cluster produced the first churn errors ever seen.
Also extend INCIDENTS.md: topology wedge 2h+, ~10% of keyspace hangs,
harness bug note.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
During the topology wedge every query failed in ~35ms, so 16 storm workers wrote ~2GB/h of identical query_error lines and nearly filled the disk (4.7M events in 45 min). Errors stay fully counted in the window stats; identical (template, cls) events now log the first 5 then every 500th, and sub-50ms failures back off 100ms so the loop can't spin at wire speed. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Final entries for incident 3: responsiveness matrix (PING/per-key fast, dead-slice + fan-out commands hang, FT.SEARCH refused), effective churn throughput collapse (~1000x) from 30s stalls on the dead slice, and end-of-session state: all client traffic stopped 16:05 UTC with the wedge still open — needs cluster-side diagnosis. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #6.
stats.event("churn_error", op=op, ...)passedoptwice (positional event name + kwarg) →TypeError→ all 8 churn workers died on their first op error. Renamed the event field tofailed_op. The bug was invisible until incident 3: the wedged cluster produced the first churn op errors the harness had ever hit.Also extends INCIDENTS.md with the latest incident-3 state: 2h+ topology wedge, ~10% of the keyspace hanging on per-key ops, stale INFO snapshots, and the harness-bug note.
🤖 Generated with Claude Code