Fix Azure SDK compatibility: use begin_* methods#529
Merged
Gauravtalreja1 merged 1 commit intoMay 19, 2026
Conversation
The newer Azure SDK versions (azure-mgmt-compute >= 30.0, azure-mgmt-network >= 25.0, azure-mgmt-resource >= 23.0) removed the synchronous delete/create_or_update/start/stop/restart/etc methods in favor of Long Running Operation (LRO) begin_* variants. This updates all Azure SDK calls in msazure.py to use the begin_* methods (begin_delete, begin_create_or_update, begin_start, begin_deallocate, begin_restart, begin_power_off, begin_capture). The generalize method remains unchanged as it is still synchronous. The existing _wait_on_operation() already handles LROPoller objects, so no additional changes are needed. Signed-off-by: Shubham Ganar <shubhamsg123m@gmail.com>
51180ff to
634e67d
Compare
Gauravtalreja1
approved these changes
May 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The newer Azure SDK versions (azure-mgmt-compute >= 30.0, azure-mgmt-network >= 25.0, azure-mgmt-resource >= 23.0) removed the synchronous delete/create_or_update/start/stop/restart/etc methods in favor of Long Running Operation (LRO) begin_* variants.
This updates all Azure SDK calls in msazure.py to use the begin_* methods (begin_delete, begin_create_or_update, begin_start, begin_deallocate, begin_restart, begin_power_off, begin_capture). The generalize method remains unchanged as it is still synchronous.
The existing _wait_on_operation() already handles LROPoller objects, so no additional changes are needed.
Test results: