Skip to content

🐛 Fix large line breaks from Jira internal comments#795

Open
C-Valen wants to merge 1 commit into
mainfrom
fix/OSIDB-5017-large-spaces-on-internal-comments
Open

🐛 Fix large line breaks from Jira internal comments#795
C-Valen wants to merge 1 commit into
mainfrom
fix/OSIDB-5017-large-spaces-on-internal-comments

Conversation

@C-Valen
Copy link
Copy Markdown
Member

@C-Valen C-Valen commented Jun 4, 2026

OSIDB-5017 Fix large line breaks from Jira internal comments

Checklist:

  • Commits consolidated
  • Changelog updated
  • [-] Test cases added/updated
  • [-] Integration tests updated

Summary:

Jira parsing makes an html paragraph each line which implicitly creates large spaces between lines.

Changes:

Remove paragraph tags from Jira html comments

@C-Valen C-Valen requested a review from a team June 4, 2026 09:59
@C-Valen C-Valen self-assigned this Jun 4, 2026
@C-Valen C-Valen added the bug Something isn't working label Jun 4, 2026
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Jun 4, 2026

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Enterprise

Run ID: 2bf611b5-3e8a-418d-b01a-dd5d940edc05

📥 Commits

Reviewing files that changed from the base of the PR and between 8d5e891 and b8de7f7.

📒 Files selected for processing (2)
  • src/components/FlawComments/CommentList.vue
  • src/components/FlawComments/FlawComments.vue

📝 Walkthrough

Summary by CodeRabbit

  • Style
    • Enhanced comment formatting with improved line breaks and optimized spacing for better readability.

Walkthrough

This PR improves flaw comment display by post-processing internal Jira comment HTML to convert paragraph tags to line breaks and collapse whitespace, while adding line-height styling to enhance readability. Non-internal comments retain their original sanitization and linkification behavior.

Changes

Comment Display Processing and Styling

Layer / File(s) Summary
Comment display processing and styling
src/components/FlawComments/CommentList.vue, src/components/FlawComments/FlawComments.vue
Internal Jira comment HTML is post-processed to replace </p><p> paragraph boundaries with <br>, strip remaining <p> tags, collapse consecutive <br> sequences, and trim the result. Comment element line-height is set to 1.4 to improve vertical spacing and readability.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly identifies the bug fix and its context (large line breaks from Jira internal comments), accurately reflecting the main objective of the PR.
Description check ✅ Passed The description covers the required sections with issue ID, summary, and changes, though non-critical sections like Considerations are missing and some checklist items remain unchecked.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/OSIDB-5017-large-spaces-on-internal-comments

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant