fix(PDF): fix export to make pdf work#2648
Merged
LightOfHeaven1994 merged 1 commit intoMay 20, 2026
Merged
Conversation
Reviewer's guide (collapsed on small PRs)Reviewer's GuideCentralizes the VULNERABILITY_BACKEND_DEPLOYMENT_NAME constant into a new shared constants module and updates existing imports so the PDF export’s module graph resolves correctly. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
bastilian
approved these changes
May 20, 2026
Member
bastilian
left a comment
There was a problem hiding this comment.
LGTM! Thank you @LightOfHeaven1994!
There was a problem hiding this comment.
Hey - I've found 1 issue
Prompt for AI Agents
Please address the comments from this code review:
## Individual Comments
### Comment 1
<location path="src/Components/SmartComponents/Reports/CVEsReport/constants.js" line_range="1" />
<code_context>
import { fetchCVEs } from '../helpers';
-
-// selecting correct vulnerability-backend deployment name
-// https://github.com/RedHatInsights/vulnerability-engine/blob/master/deploy/clowdapp.yaml
-export const VULNERABILITY_BACKEND_DEPLOYMENT_NAME = 'manager-service';
+import { VULNERABILITY_BACKEND_DEPLOYMENT_NAME } from './constants';
</code_context>
<issue_to_address>
**issue (review_instructions):** This change introduces a new file, which violates the instruction to avoid file-level changes.
The review instructions explicitly say not to make file-level changes, but this PR adds a new `constants.js` file. If possible, the new constant should be placed into an existing file instead of creating a new one, or the change should be cleared with whoever provided the instructions.
<details>
<summary>Review instructions:</summary>
**Path patterns:** `*`
**Instructions:**
Do not generate any diagrams (class, ER, etc.) or file level changes
</details>
</issue_to_address>Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
wrong export affected dependency graph and as the result pdf export was failing with
Summary by Sourcery
Centralize the vulnerability backend deployment name in a shared constants module and update reports to consume it from there.
Bug Fixes:
Enhancements: