Skip to content

chore(deps): update multiple packages for foreman-3.18#2340

Merged
jdobes merged 1 commit into
RedHatInsights:foreman-3.18from
pfreyburg:bump-urllib3-python-multipart-foreman-3.18
May 18, 2026
Merged

chore(deps): update multiple packages for foreman-3.18#2340
jdobes merged 1 commit into
RedHatInsights:foreman-3.18from
pfreyburg:bump-urllib3-python-multipart-foreman-3.18

Conversation

@pfreyburg
Copy link
Copy Markdown

@pfreyburg pfreyburg commented May 14, 2026

Jira

SAT-41420
SAT-41475
SAT-41979

Secure Coding Practices Checklist GitHub Link

Secure Coding Checklist

  • Input Validation
  • Output Encoding
  • Authentication and Password Management
  • Session Management
  • Access Control
  • Cryptographic Practices
  • Error Handling and Logging
  • Data Protection
  • Communication Security
  • System Configuration
  • Database Security
  • File Management
  • Memory Management
  • General Coding Practices

Summary by Sourcery

Update dependency versions for compatibility with foreman-3.18 and align runtime requirements across configuration files.

Enhancements:

  • Bump python-multipart and urllib3 versions in production requirements to newer, compatible releases.
  • Declare minimum versions for urllib3 and python-multipart in pyproject.toml to keep package metadata in sync with pinned requirements.

@sourcery-ai
Copy link
Copy Markdown

sourcery-ai Bot commented May 14, 2026

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

This PR updates two runtime dependencies (python-multipart and urllib3) to newer versions for the Python 3.12 environment and aligns pyproject.toml constraints accordingly to support the Foreman 3.18 stack.

File-Level Changes

Change Details Files
Bump python-multipart runtime dependency and align project constraint.
  • Increase python-multipart from 0.0.20 to 0.0.28 for Python 3.12 runtime in requirements.txt
  • Update pinned hashes for the new python-multipart version in requirements.txt
  • Add an explicit python-multipart >=0.0.28 dependency constraint in pyproject.toml
requirements.txt
pyproject.toml
Bump urllib3 runtime dependency and align project constraint.
  • Increase urllib3 from 2.5.0 to 2.7.0 for Python 3.12 runtime in requirements.txt
  • Update pinned hashes for the new urllib3 version in requirements.txt
  • Add an explicit urllib3 >=2.7.0 dependency constraint in pyproject.toml
requirements.txt
pyproject.toml

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link
Copy Markdown

@sourcery-ai sourcery-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@pfreyburg pfreyburg force-pushed the bump-urllib3-python-multipart-foreman-3.18 branch from 7b7bacd to 98db5fc Compare May 14, 2026 14:32
@pfreyburg pfreyburg requested review from jdobes and vkrizan May 14, 2026 14:35
@jdobes jdobes merged commit 29aeae1 into RedHatInsights:foreman-3.18 May 18, 2026
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants