Skip to content

fix(deps): bump urllib3 to 2.6.3#2280

Open
Odilhao wants to merge 1 commit into
RedHatInsights:foreman-3.16from
Odilhao:fix/bump-urllib3-CVE-2025-foreman-3.16
Open

fix(deps): bump urllib3 to 2.6.3#2280
Odilhao wants to merge 1 commit into
RedHatInsights:foreman-3.16from
Odilhao:fix/bump-urllib3-CVE-2025-foreman-3.16

Conversation

@Odilhao
Copy link
Copy Markdown

@Odilhao Odilhao commented Apr 7, 2026

Summary

Bumps urllib3 from 2.5.0 to 2.6.3 to address CVE-2025-4632.

Changes

  • pyproject.toml: adds explicit urllib3 = ">=2.6.3" lower-bound constraint (was previously only a transitive dependency via requests/aiohttp)
  • poetry.lock: introduced on this branch (was absent); generated via poetry update urllib3
  • requirements.txt: regenerated with correct SHA-256 hashes via make generate-requirements-txt — collateral version bumps within project constraints are included

Regeneration steps used

# 1. Add urllib3 = ">=2.6.3" to [tool.poetry.dependencies] in pyproject.toml
# 2. Create poetry.lock and resolve urllib3
poetry update urllib3
# 3. Re-export hash-pinned requirements.txt
make generate-requirements-txt

CVEs fixed

Made with Cursor

Copy link
Copy Markdown

@sourcery-ai sourcery-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry @Odilhao, your pull request is larger than the review limit of 150000 diff characters

@Odilhao Odilhao force-pushed the fix/bump-urllib3-CVE-2025-foreman-3.16 branch from 021cdcf to 8533bcb Compare April 14, 2026 13:08
@jdobes jdobes force-pushed the fix/bump-urllib3-CVE-2025-foreman-3.16 branch from 8533bcb to 0ff5688 Compare April 22, 2026 12:11
@jdobes
Copy link
Copy Markdown
Member

jdobes commented Apr 22, 2026

@Odilhao There is also 'urllib3==2.5.0' in requirements-dev.txt, pls bump it also there to make tests pass

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants