chore: migrate urfave cli to v3

[Peto-RH]

• Card ID: CCT-2122

Update rhc to use urfave/cli v3 while preserving existing command behavior.

[Peto-RH]

Note for reviewer: I removed yaml license from go-vendor-tools.toml as cli/v3 no longer needs that yaml dependency

[mjcr99]

GJ @Peto-RH, I leave you a couple of comments.
I would also consider referring to the Card ID in the second commit.

[mjcr99]

Before these changes, we were verifying the config file in the beforeaction section. Should we consider it?

[Peto-RH]

Hi, good question. I was also brainstorming about this.
The 2 functions NewTomlSourceFromFile and ApplyInputSourceValues do not exist anymore in v3, and v3 unfortunately does not have a 1-to-1 solution for this. There are basically 2 problems:

1. How do we keep validating the config file before every command action runs? (this is the one you are probably asking about)
2. How do we propagate errors and return an error code upon parsing failure?

There are multiple approaches:

1. Do it the v3 idiomatic way. This is the approach I currently proposed with the new commit.

• That means - do not validate the config file in beforeAction (validate only in main())
• Do not report or catch parsing errors.

2. Set the URFAVE_CLI_TRACING=on env variable (for example in the .spec file). With this variable, the logs will show that the parsing failed, but this will not affect the program.
3. Add some custom functionality to validate the toml. I am doubtful about this one because it would require some 3rd party lib to be imported. This would probably look something like this.

import "github.com/pelletier/go-toml"

func beforeAction(ctx context.Context, cmd *cli.Command) (context.Context, error) {
    // some code ...
    configPath := cmd.String("config")
    if configPath != "" {
    if _, err := os.Stat(configPath); err == nil {
	    // File exists, validate it's parseable TOML
	    if _, err := toml.LoadFile(configPath); err != nil {
		    return ctx, fmt.Errorf("invalid config file %s: %w", configPath, err)
	    }
    }
    // some more code ...
}

What do you think should be our approach to this? Do you have any other ideas?

FYI, the only toml-connected function in v3 is the TOML function that we are using in the new version, for example here altsrctoml.TOML(cliCertFile, configSource).
Here is the documentation for toml in v3

[pkoprda]

Please resolve conflicts