feat(cli): rhc collector CLI#425
Merged
Merged
Conversation
918292f to
4ed2eee
Compare
m-horky
requested changes
Apr 30, 2026
Collaborator
m-horky
left a comment
There was a problem hiding this comment.
I have not discovered any significant issues, overall the code feels solid and considering the state of the codebase well structured.
UX notes:
- With no data collector,
listoutputsfailed to list collectors: EOF. Could we display some better message, like "Error: No data collectors are available"? rhc collector timersdoes not display the value of NEXT, even when the timer is enabled. It may be because we aren't passing--allflag tosystemctl list-timers.
More inline.
4ed2eee to
1d79ba0
Compare
m-horky
previously approved these changes
May 4, 2026
Collaborator
m-horky
left a comment
There was a problem hiding this comment.
Nothing stands out, you have my ACK. I'm leaving the resolution of the rest of my comments up to you.
* Card ID: CCT-1845 Add functions for formatting collector information and timers: - FormatCollectorInfo() for detailed collector display - PrintCollectorTimers() for tabular timer information - PrintTable() utility for formatted table output Supports both human-readable and JSON output formats. Assisted-By: Claude Code <noreply@anthropic.com>
* Card ID: CCT-1845 Add IsSystemdAvailable() function to detect if systemd is present in the current environment. Returns false in containers or environments where systemd is not running. - Add ValidateCollectorAndConnect() function for collector enable/disable operations - Includes systemd detection, collector validation, and connection setup Assisted-By: Claude Code <noreply@anthropic.com>
The systemctl list-timers command without --all flag only show active timers. For enabled but inactive timers, the --all flag is needed to display next run times.
* Card ID: CCT-1845 Add comprehensive collector CLI interface with commands: - rhc collector info <ID> - Display collector information - rhc collector list - List available collectors - rhc collector timers - List collector timers - rhc collector enable [--now] <ID> - Enable timer-based collection - rhc collector disable [--now] <ID> - Disable timer-based collection Assisted-By: Claude Code <noreply@anthropic.com>
1d79ba0 to
35ccf3c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add comprehensive collector CLI interface with commands:
An example of how to test this PR: