fix(rhc): Default to 'debug' log level#50
Merged
Merged
Conversation
rhc used to use github.com/subpop/go-log logging library, and switched to log/slog semi-recently. The Go standard library does not define a TRACE log level, which made one test fail: test_logging.py::test_log_connect_with_disabled_feature
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
rhc used to use github.com/subpop/go-log logging library, and switched to log/slog semi-recently. The Go standard library does not define a TRACE log level, which made one test fail:
test_logging.py::test_log_connect_with_disabled_feature
This patch affects both yggdrasil and rhc. If any Yggdrasil test relies on the implicit behavior, it will have to be updated.