Skip to content

fix: make filter reset behavior consistent #1623

Open
dominikvagner wants to merge 1 commit into
RedHatInsights:masterfrom
dominikvagner:fix-reset-filter-behavior-3
Open

fix: make filter reset behavior consistent #1623
dominikvagner wants to merge 1 commit into
RedHatInsights:masterfrom
dominikvagner:fix-reset-filter-behavior-3

Conversation

@dominikvagner
Copy link
Copy Markdown
Collaborator

This fixes some of the incorrect behavior with filter clear or reset
buttons. They should now only be shown when the state differs from
default and use correct terms for restoring and clearing (depends on
default filters).

@dominikvagner dominikvagner requested a review from a team as a code owner May 13, 2026 13:49
@dominikvagner dominikvagner force-pushed the fix-reset-filter-behavior-3 branch from f37e48d to 826bf6d Compare May 13, 2026 13:50
@codecov-commenter
Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 98.16514% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 77.58%. Comparing base (3893665) to head (826bf6d).

Files with missing lines Patch % Lines
src/Utilities/Helpers.js 98.18% 1 Missing ⚠️
src/Utilities/hooks/Hooks.js 92.30% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1623      +/-   ##
==========================================
+ Coverage   76.21%   77.58%   +1.37%     
==========================================
  Files         103      103              
  Lines        3187     3266      +79     
  Branches      693      734      +41     
==========================================
+ Hits         2429     2534     +105     
+ Misses        678      655      -23     
+ Partials       80       77       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@TenSt TenSt self-assigned this May 14, 2026
@dominikvagner dominikvagner changed the title fix: dark mode support and spacing system detail fix: make filter reset behavior consistent May 15, 2026
@dominikvagner dominikvagner enabled auto-merge (rebase) May 15, 2026 17:23
This fixes some of the incorrect behavior with filter clear or reset
buttons. They should now only be shown when the state differs from
default and use correct terms for restoring and clearing (depends on
default filters).
@dominikvagner dominikvagner force-pushed the fix-reset-filter-behavior-3 branch from 826bf6d to 93bef4b Compare May 18, 2026 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants