Skip to content

create some workspaces for generated hosts#2201

Merged
MichaelMraka merged 1 commit into
RedHatInsights:masterfrom
MichaelMraka:pr1
May 18, 2026
Merged

create some workspaces for generated hosts#2201
MichaelMraka merged 1 commit into
RedHatInsights:masterfrom
MichaelMraka:pr1

Conversation

@MichaelMraka
Copy link
Copy Markdown
Collaborator

@MichaelMraka MichaelMraka commented May 18, 2026

Secure Coding Practices Checklist GitHub Link

Secure Coding Checklist

  • Input Validation
  • Output Encoding
  • Authentication and Password Management
  • Session Management
  • Access Control
  • Cryptographic Practices
  • Error Handling and Logging
  • Data Protection
  • Communication Security
  • System Configuration
  • Database Security
  • File Management
  • Memory Management
  • General Coding Practices

Summary by Sourcery

Generate realistic workspace metadata for test systems in the data generation script.

Enhancements:

  • Increase the volume of generated systems to better approximate production scale.
  • Assign generated systems to a small set of workspaces with IDs and names to simulate workspace usage in test data.

@MichaelMraka MichaelMraka requested a review from a team as a code owner May 18, 2026 13:43
@sourcery-ai
Copy link
Copy Markdown

sourcery-ai Bot commented May 18, 2026

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Test data generation script now creates significantly more systems and assigns each generated system to one of three new workspaces with consistent IDs and names.

File-Level Changes

Change Details Files
Increase the volume of generated test systems to better approximate production scale.
  • Update the '_const' configuration to generate 7,500 systems instead of 10.
  • Keep other constant configuration values unchanged.
dev/test_generate_data.sql
Assign generated systems to a small, fixed set of workspaces for testing workspace-related functionality.
  • Introduce a local workspace_ids UUID array and populate it with three generated UUIDs at the start of the data-generation loop.
  • Extend system_inventory insert statements to populate workspace_id and workspace_name columns for each generated system.
  • Derive workspace_id and workspace_name from workspace_ids using a modulo-based index to distribute systems across three workspaces.
dev/test_generate_data.sql

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link
Copy Markdown

@sourcery-ai sourcery-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@codecov-commenter
Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 59.03%. Comparing base (836502e) to head (a70d4ee).
⚠️ Report is 8 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2201      +/-   ##
==========================================
- Coverage   59.06%   59.03%   -0.04%     
==========================================
  Files         136      136              
  Lines        8761     8761              
==========================================
- Hits         5175     5172       -3     
- Misses       3040     3043       +3     
  Partials      546      546              
Flag Coverage Δ
unittests 59.03% <ø> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@TenSt TenSt self-assigned this May 18, 2026
@MichaelMraka MichaelMraka merged commit 0579a04 into RedHatInsights:master May 18, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants