RHINENG-26117: Add recompute infrastructure for account_advisory#2195
Draft
rverdile wants to merge 4 commits into
Draft
RHINENG-26117: Add recompute infrastructure for account_advisory#2195rverdile wants to merge 4 commits into
rverdile wants to merge 4 commits into
Conversation
adds a new table for account advisories by workspace, but does not wire-up the table to anything
…dvisory Add SQL functions that mirror advisory_account_data functions to populate account_advisory table
Reviewer's GuideAdds a new workspace-scoped account_advisory aggregate table with full schema, migrations, recompute/backfill functions, and system_inventory triggers, plus Go model/test helpers and integration tests to validate recompute and trigger behavior. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2195 +/- ##
==========================================
- Coverage 59.06% 58.86% -0.21%
==========================================
Files 136 136
Lines 8761 8791 +30
==========================================
Hits 5175 5175
- Misses 3040 3070 +30
Partials 546 546
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This adds recompute and trigger infrastructure for account_advisory. It's mostly modeled after the existing recompute and trigger for account_advisory_data. I also added a little bit of Go infrastructure so that I could add unit tests.
This is dependent on this PR: #2184
Secure Coding Practices Checklist GitHub Link
Secure Coding Checklist
Summary by Sourcery
Introduce workspace-scoped account_advisory aggregation with recompute and trigger support, plus supporting Go model and tests.
New Features:
Enhancements:
Documentation:
Tests: