RHCLOUD-29047 | feature: implement email sending settings#103
RHCLOUD-29047 | feature: implement email sending settings#103MikelAlejoBR wants to merge 2 commits into
Conversation
MikelAlejoBR
force-pushed
the
RHCLOUD-29047-implement-email-sending-settings
branch
2 times, most recently
from
78e4954 to
1b3021c
Compare
|
/retest |
6 similar comments
|
/retest |
|
/retest |
|
/retest |
|
/retest |
|
/retest |
|
/retest |
dagbay-rh
left a comment
dagbay-rh
left a comment
There was a problem hiding this comment.
all the new logic looks good to me! only thing I am wondering about: are there tests we can add/update to cover the new logic in send_email.go? im not very familiar with mbop so apologies not knowing the tests setup
|
the pr build is failing due to: seems related to bonfire stuffs happening. our unit tests are passing so I think this should be ok to ignore for now. not totally sure who would know more about these builds tho, would be nice to see if we can get them passing or fix them etc |
I really have no idea. Maybe I can try to build a mock for the SendEmails function? |
|
Hi everyone! Any chance this could be merged soon? |
|
Hello, I need to take a look at those tests and implement them. I'll get to it. |
The back office proxy supoports skipping the user resolution and overriding the email's sender and the email's default recipients, and the idea of these changes is for MBOP to support the same things too. RHCLOUD-29047
MikelAlejoBR
force-pushed
the
RHCLOUD-29047-implement-email-sending-settings
branch
2 times, most recently
from
c8f5b8a to
a45349c
Compare
|
I've added a few tests as requested @dagbay-rh |
MikelAlejoBR
force-pushed
the
RHCLOUD-29047-implement-email-sending-settings
branch
3 times, most recently
from
8168e13 to
bf71a33
Compare
RHCLOUD-29047
MikelAlejoBR
force-pushed
the
RHCLOUD-29047-implement-email-sending-settings
branch
from
bf71a33 to
fd8e70c
Compare
|
/retest |
2 similar comments
|
/retest |
|
/retest |
|
I am fine with merging this 👍 The logic looks good to me! I think the last PR we merged was also failing the PR check so i do not think its related to your PR. |
|
Let's make sure this PR won't create any issues in the special environment before it is merged. Until then...
|
|
@MikelAlejoBR test it in ephemeral |
5 participants
The back office proxy supports skipping the user resolution and overriding the email's sender and the email's default recipients, and the idea of these changes is for MBOP to support the same things too.
Jira ticket
[RHCLOUD-29047]