Skip to content

Fix prettier issues and update PR contract#318

Merged
apinkert merged 2 commits into
RedHatInsights:masterfrom
apinkert:fix-prettier
May 13, 2026
Merged

Fix prettier issues and update PR contract#318
apinkert merged 2 commits into
RedHatInsights:masterfrom
apinkert:fix-prettier

Conversation

@apinkert
Copy link
Copy Markdown
Collaborator

@apinkert apinkert commented May 13, 2026

Fixes prettier issues that mistakenly got merged and updates the on-pull-request contract to check for lint issues

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 13, 2026

Walkthrough

Adds a lint step to the Tekton pipeline run script and makes minor formatting/whitespace edits to two Storybook story files; no behavioral or API changes to application code.

Changes

Storybook story formatting

Layer / File(s) Summary
Reformat assertion
src/components/HelpPanel/HelpPanelTabs/SupportPanel.stories.tsx
Reformatted the WithCases story's toBeGreaterThan(0) assertion to a multi-line style; behavior unchanged.
Trailing-whitespace cleanup
src/user-journeys/HelpPanelSupportPanel.stories.tsx
Removed trailing newline/whitespace at the end of the Step04_EmptyStateAndOpenSupportCase story file; no logic changes.

CI: Tekton pipeline update

Layer / File(s) Summary
Add lint step to unit test script
.tekton/learning-resources-pull-request.yaml
unit-tests-script now runs npm run lint before npm test -- --runInBand --no-cache; pipeline structure and other tasks unchanged.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Description check ❓ Inconclusive The PR description is vague and lacks required sections from the template (ticket reference, screenshots, checklist, and detailed explanation). Provide a complete description including RHCLOUD ticket reference, detailed explanation of prettier issues fixed, relevant screenshots/Storybook links, completed checklist items, and any reviewer notes.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately reflects the main changes: fixing Prettier formatting issues and updating the PR contract to include linting.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

@apinkert apinkert changed the title Fix prettier issues Fix prettier issues and update PR contract May 13, 2026
@apinkert apinkert merged commit ea808f3 into RedHatInsights:master May 13, 2026
9 checks passed
@apinkert apinkert deleted the fix-prettier branch May 13, 2026 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants