Call setPlacedBy with the Placer Block's Player to transfer components when placing blocks#708
Open
epiccoleman wants to merge 1 commit intoRearth:1.21from
Open
Conversation
…s to placed blocks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a call to setPlacedBy, using the Placer Block's Player entity, when the Placer machine places a block.
This ensures that placed blocks, like Portable Tanks, utilize their internal logic for copying custom components (like Fluid count) when placed by the Placer block.
Fixes #707
How Has This Been Tested?
Tested in both Neoforge 21.2.219 and Fabric 0.18.4, using the same apparatus used to produce the bug described in #707 .
With the fix in place, when a filled portable tank is placed by the Placer Block, the tank is placed with the appropriate amount of fluid, as a player might intuitively expect.