Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was wrong?
Ream has not covered all bases where a bad or malicious peer feeding improper data into Ream via sync is protected. Currently if Ream is seeded a bad root from an improper checkpoint on genesis it will error and crash as the forward sync attempts to walk back to a previously stored root which does not exist at genesis. If the bad root is given during regular runtime it does not immediately error, however the queue responsible for the root currently sits in circulation and has no mechanism to kick it out, or to penalize and avoid the peer feeding the bad checkpoint.
How was it fixed?
There are several mechanisms added or modified to protect against this issue:
To-Do