fix: Dependabot Friday schedule and CodeQL alert #1 - #38
Merged
Merged
Conversation
Dependabot: add day/time/timezone to both ecosystems so scans run Friday at 08:00 America/New_York instead of the default (Monday, random time UTC). CodeQL alert #1 (py/incomplete-url-substring-sanitization): CodeQL flagged test_keeps_scheme_and_host for using startswith() against a URL string, which it treats as an incomplete sanitization pattern. The production _redact_url() already uses urlsplit() correctly; the test assertion was simply imprecise. Replace startswith() with assertEqual() against the exact expected output — tighter test, no CodeQL flag. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01PhSFmsQDhrUoFR7F8EHkD5
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Dependabot schedule: both ecosystems (github-actions, docker) now run weekly on Friday at 08:00 America/New_York instead of the GitHub default (Monday, random UTC time). Adds
day,time, andtimezoneto both entries independabot.yml.CodeQL alert Phase 1 MVP: GitHub backup, hardened Docker, tests, CI #1 (
py/incomplete-url-substring-sanitization): CodeQL flaggedtest_keeps_scheme_and_hostintests/test_webserver.pyfor usingstartswith('https://hooks.slack.com')— a pattern it flags as incomplete URL sanitization. This is a false positive: the check is a test assertion on the output of_redact_url(), not a sanitization guard. The production code usesurlsplit()correctly. Fixed by replacing the imprecisestartswithassertion with an exactassertEqualagainst the full expected output ('https://hooks.slack.com/…[redacted]'), which is both more precise and no longer triggers the rule.Test plan
🤖 Generated with Claude Code
https://claude.ai/code/session_01PhSFmsQDhrUoFR7F8EHkD5