Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 21 additions & 0 deletions packages/rxjs/src/take-last.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,27 @@ describe('takeLast', () => {
expect(subscriptions).toBe(0);
});

it('buffers every value for Infinity and emits them on completion', () => {
const events: Array<number | 'complete'> = [];
const errors: unknown[] = [];
const source = new Observable<number>((subscriber) => {
subscriber.next(1);
subscriber.next(2);
subscriber.next(3);
expect(events).toEqual([]);
subscriber.complete();
});

source[takeLast](Infinity).subscribe({
next: (value) => events.push(value),
error: (error) => errors.push(error),
complete: () => events.push('complete'),
});

expect(errors).toEqual([]);
expect(events).toEqual([1, 2, 3, 'complete']);
});

it('exposes the extension through the exported Symbol only', () => {
const source = new Observable<number>(() => {});
type HasStringNamedTakeLast = Observable<number> extends { takeLast: unknown } ? true : false;
Expand Down
2 changes: 1 addition & 1 deletion packages/rxjs/src/take-last.ts
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ Observable.prototype[takeLast] = function <T>(this: Observable<T>, amount = 1):
return;
}

let ring = new Array<T>(amount);
let ring = amount === Infinity ? [] : new Array<T>(amount);
let counter = 0;
subscriber.addTeardown(() => {
ring = null!;
Expand Down