docs(release): release PR 上没有 CI 检查这件事必须写下来(并纠正我在 #123 里的假设) - #128
Merged
Merged
Conversation
实测 #120:`gh pr checks 120` 是空的。原因是 GitHub 的固定行为——由 GITHUB_TOKEN 产生的 提交不再级联触发 workflow,而 release PR 的提交正是 bot 用 GITHUB_TOKEN 推的。 这推翻了我自己在 #123 里写下的假设("下一条 release PR 上红在手工位是预期行为,补一个 commit 即可"):那些闸不会在 PR 上红,会红在合并之后的 main 上 —— 那时 Release 已经发出去了。 所以 §1 的第 1 条路补一句硬性动作:合 release PR 之前本地跑 `.venv/Scripts/python.exe -m pytest tests/test_version_consistency.py`。 Signed-off-by: ReSerendipity <zengyangc@outlook.com>
ReSerendipity
added a commit
that referenced
this pull request
Sep 22, 2026
v2.2.5 发完之后核对下游:`gh run list --workflow docker-publish.yml` 上 v2.2.2 / v2.2.3 / v2.2.4 各有一条 `ev=push br=vX.Y.Z`,**v2.2.5 一条都没有**;`gpg-signed-release.yml` 同理 (三条 `ev=release`,2.2.5 缺席)。原因是同一条 GitHub 固定行为 —— bot 用 `GITHUB_TOKEN` 产生的事件不级联,而 RP 打的 tag 和建的 Release 正是它产的。#128 只写过"release PR 拿不到 CI" 这一面,没写它会连带吃掉 tag/release 两个下游触发,于是本次实测才发现。 后果是具体的:`deploy/kubernetes/deployment.yaml:40,61` 手工同步到了 `ghcr.io/reserendipity/tts-multimodel:2.2.5`,而 ghcr 上今天没有这个标签。两处都不能退回 2.2.4 消红(`test_all_version_sites_agree` 会把版本位一致性判红),所以唯一的自洽修法是补跑 `gh workflow run docker-publish.yml --ref v2.2.5` —— `metadata-action` 的 `type=semver` 在 tag ref 上就能出 `:2.2.5`,工作流不用改。这一步按"Release 侧动作交回 owner"的约定留给所有者点头。 顺带修一处已经过期的话:§1 末尾那段还在说"要把它变成机器闸就得配一个能报 commit status 的作业 —— 那是权限决策,不在现状里",而 #134 已经把它建出来了(报 `release-gate`、不拦截)。 GPG 那一格现在不痛(`GPG_PRIVATE_KEY` 未配 → 作业进 skip 分支只出 notice),但密钥配上之后 RP 发的每个版本都要手工补跑,这条也写进 §1 第 4 条,免得下次又当成"自动路径会替我做"。 验证:`pytest tests/test_version_consistency.py tests/test_release_readiness_gate.py tests/test_docker_cache_budget.py` → 14 passed(basetemp 换掉才跑起来: `pytest-of-Doro/pytest-current` 有残留目录导致 WinError 5,与本改动无关)。 `已发布最新 = v2.2.5` 一行未动,第 10 处版本位仍与 9 处代码位一致。 Signed-off-by: ReSerendipity <zengyangc@outlook.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.