Repository navigation
fix(packages): do not call a Docker that is behind up to date - #15
Merged
Merged
Conversation
A docker-ce on hold (apt-mark hold), or kept back by apt, has no update listed and was shown as up to date, though a newer version exists in its package sources. The Docker line now carries that newer version (candidate) and whether the package is on hold, and the manual command allows the change of a held package.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Docker line of the System packages check said nothing was pending, and the dashboard said 'up to date', for a Docker 28.0.4 whose package is on hold (or kept back by apt): apt lists no Inst line for such a package, so nothing was pending as far as the update is concerned, though a newer version exists in its sources.
The check now reads the installed and the candidate version from
apt-cache policyof the engine package and, when the candidate is later (dpkg's own comparison) and no update is listed for it, says so:candidateandheld(dpkg's status abbreviation starts with h) in thedockerobject. The manual command for a held package carries--allow-change-held-packages, which apt needs to upgrade a held package named on the command line. Tests for both cases and for a Docker that really is current.