Repository navigation
feat(packages): show Docker on a line of its own in System packages - #18
Merged
Merged
Conversation
The core now leaves Docker's packages out of the update and reports them separately: the modal shows Docker's version, where it came from, what it has on offer, a warning that updating it restarts it and stops every container, and the command to type to do it by hand. The confirmation says Docker is not part of the update.
…e dialogs The Docker line no longer says 'up to date' of a snap or of a Docker whose source apt cannot see, shows the snap's command, warns of a restart only when the pending packages restart Docker, and says 'no other updates' next to it; the confirmation names Docker only when the core reported it; a refusal of the ReCasaOS update (409) gives its button back with the reason instead of spinning for ever; a refused package update shows the reason once and checks the list again; the lint passes (a lookup table instead of a switch); the command is reachable by keyboard; French wording.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Goes with ReCasaOS/CasaOS#14: the core no longer installs Docker's packages in the System packages update and reports them in a separate
dockerobject (engine version, origin, what apt offers, a constant command to type to update it oneself).The modal shows that line under the list: Docker's version and where it came from (Docker's repository, the distribution's docker.io, snap, unknown), what is on offer, the warning that updating Docker restarts it and stops every container until it is back (apps with a restart policy start again, the others stay stopped), and the command, selectable. Up to date, unknown origin (no command, and it says why) and no Docker are handled. The confirmation now says Docker is not part of the update. English and French; specs for each case.