Repository navigation
Keep encrypted volumes from being offered for formatting - #4
Merged
Merged
Conversation
A locked LUKS container or a BitLocker volume mounts nothing and holds a format CasaOS cannot read, so its disk was listed as available storage with formatting as the only action. Both signatures now count as in use, like RAID, LVM and ZFS members. An opened LUKS stack (dm-crypt, LVM, ext4 mounted from fstab, as reported upstream in IceWhaleTech/CasaOS-LocalStorage#73) was already kept out by the walk down the stack; it gets a test.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A locked LUKS container or a BitLocker volume (a Windows partition on a dual-boot box) mounts nothing and holds a format CasaOS cannot read, so its disk was listed as available storage with formatting as the only action. Both now count as in use, like RAID, LVM and ZFS members.
Prompted by IceWhaleTech/CasaOS-LocalStorage#73: its case, LUKS then dm-crypt then LVM then an ext4 mounted from fstab, was already kept out here by the walk down the whole stack, and now has a test.